Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for empty dimension id from a plugin #17690

Merged
merged 1 commit into from
May 17, 2024

Conversation

stelfrag
Copy link
Collaborator

@stelfrag stelfrag commented May 17, 2024

Summary
  • Check for empty dimension or dimension creation failure and disable plugin

Fixes #17671

@github-actions github-actions bot added area/collectors Everything related to data collection collectors/plugins.d labels May 17, 2024
@stelfrag stelfrag marked this pull request as ready for review May 17, 2024 09:16
@stelfrag stelfrag requested a review from thiagoftsm as a code owner May 17, 2024 09:16
@stelfrag stelfrag requested a review from ilyam8 May 17, 2024 09:17
@stelfrag stelfrag merged commit a33b13f into netdata:master May 17, 2024
148 of 149 checks passed
@stelfrag stelfrag deleted the handle_empty_dimension_id branch May 17, 2024 10:54
stelfrag added a commit to stelfrag/netdata that referenced this pull request May 17, 2024
Check for empty dimension or dimension creation failure and disable plugin

(cherry picked from commit a33b13f)
@stelfrag stelfrag mentioned this pull request May 17, 2024
Ferroin pushed a commit that referenced this pull request May 21, 2024
Check for empty dimension or dimension creation failure and disable plugin

(cherry picked from commit a33b13f)
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request May 27, 2024
https://build.opensuse.org/request/show/1176835
by user mia + anag+factory
- Update to 1.45.5
  * Fixed streaming sender functions payload corruption
    gh#netdata/netdata#17696
  * Fixed crashes due to missing dimension IDs (external protocol)
    by detecting incorrect syntax and disabling plugins
    gh#netdata/netdata#17690
  * Fixed calculation issue in the go.d/cockroachdb collector
    gh#netdata/netdata#17659
- Changes in 1.45.4
  * Added missing update_every property to the health prototype
    JSON schema
    gh#netdata/netdata#17613
  * Fixed issue where parent alerts remained active after child
    disconnection, by resetting health on child disconnect
    gh#netdata/netdata#17612
  * Increased spawn server command size and added shutdown
    safeguard to prevent crashes from command size limit exceeded
    gh#netdata/netdata#17566
  * Fixed error cod
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/collectors Everything related to data collection collectors/plugins.d
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: netdata plugins segfaults after update 1.45.3 to 1.45.4
2 participants