dyncfg files on disk do not contain colons #17694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktsaou
force-pushed
the
dyncfg-illegal-filenames
branch
from
3b111a0
to
17b7fb4
Compare
github-actions
bot
added
area/health
area/collectors
|
The issue with this change is that existing installations have both files ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For windows compatibility, dyncfg files on disk do not contain colons.
Existing files are renamed on netdata startup to escape the colons. The code will work even if new restrictions are added to the filenames.
Schema files are renamed in git repo to use the latest filename limits set.