Update netdata-agent-security.md #17738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyam8
reviewed
May 23, 2024
| @@ -1,5 +1,9 @@ | |||
| # Backing up a Netdata Agent | |||
|
|
|||
| > **Note** | |||
| > | |||
| > With Netdata's decentralised / distributed architecture the data and metrics are always stored locally (on the user's host), it is the user's responsibility to backup, recover and ensure his data is available. | |||
There was a problem hiding this comment.
Suggested change
| > With Netdata's decentralised / distributed architecture the data and metrics are always stored locally (on the user's host), it is the user's responsibility to backup, recover and ensure his data is available. | |
| > **Note** | |
| > | |
| > Users are responsible for backing up, recovering, and ensuring their data's availability because Netdata stores data locally on each system due to its decentralized architecture. |
There was a problem hiding this comment.
Stress on "Users are responsible" instead of "decentralised / distributed" because that is the point you are making here.
There was a problem hiding this comment.
@sashwathn see my reasoning for changing the wording above. If you don't like the new version I can undo my changes.
ilyam8
reviewed
May 23, 2024
ilyam8
reviewed
May 23, 2024
ilyam8
approved these changes
May 23, 2024
sashwathn
approved these changes
May 23, 2024
lechgu
pushed a commit
to SaladTechnologies/netdata
that referenced
this pull request
May 23, 2024
* Update netdata-agent-security.md * Update backup-and-restore-an-agent.md * Update backup-and-restore-an-agent.md * Update netdata-agent-security.md * Apply suggestions from code review * Update docs/netdata-agent/backup-and-restore-an-agent.md --------- Co-authored-by: Ilya Mashchenko <ilya@netdata.cloud>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@sashwathn added the snippet into the two files, in the spot that felt the best. If you have any edit suggestions, commit them and let's merge.