Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update netdata global stats and enable them by default #18001

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

ilyam8
Copy link
Member

@ilyam8 ilyam8 commented Jun 24, 2024

Summary

I noticed that

  • We use the netdata.uptime metric in some of our alerts.
  • This metric is not collected because it is a part of global_statistics_main() that is disabled by default.
  • It is disabled by default because global_statistics_main() produces too many metrics and most of them are only needed/understood by developers.

This PR:

  • Move the majority of global stats to extended. Create STATS_GLOBAL_EXT thread:
    • extended global stats
    • workers stats
    • sqlilte3 stats
  • Enable "netdata monitoring" by default.

This PR does not:

  • Some important metrics (such as the number of dbengine metrics/memory usage) should be enabled by default. They are not currently enabled (they are part of the extended metrics). There are more metrics we need to enable by default (e.g. streaming). cc @stelfrag
Test Plan

Install and check "Netdata Monitoring" section.

Additional Information
For users: How does this change affect me?

@ilyam8 ilyam8 marked this pull request as ready for review June 24, 2024 11:44
@ilyam8 ilyam8 changed the title update global status and enable them by default update netdata global stats and enable them by default Jun 24, 2024
Copy link
Contributor

@thiagoftsm thiagoftsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is working as expected:

24817 25060 ?        00:00:00 P[idlejitter]
24817 25061 ?        00:00:00 HEALTH
24817 25062 ?        00:00:00 STATS_GLOBAL
24817 25063 ?        00:00:00 STATS_GLOBAL_EX
24817 25064 ?        00:00:00 PLUGINSD
24817 25065 ?        00:00:00 SERVICE
24817 25066 ?        00:00:00 STATSD_FLUSH
24817 25068 ?        00:00:00 WEB[1]

@stelfrag
Copy link
Collaborator

Ok we can review more useful stats to enable in a future PR.

Note that if we notice gaps in charts we will consider moving sqlite stats in another thread. Some of the functions that get stats may take longer than expected.

Copy link
Collaborator

@stelfrag stelfrag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilyam8 ilyam8 merged commit 52c2307 into netdata:master Jun 25, 2024
149 checks passed
@ilyam8 ilyam8 deleted the move-unimportant-stats-ext-thread branch June 25, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants