Explicitly disable logsmanagement plugin on known-broken environments. #18002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, just disable it by default, because we don’t really support it.
thiagoftsm
approved these changes
Jun 25, 2024
stelfrag
pushed a commit
to stelfrag/netdata
that referenced
this pull request
Jul 3, 2024
netdata#18002) * Explicitly disable logsmanagement plugin on known-broken environments. Also, just disable it by default, because we don’t really support it. * Fix logic for disabling logs management plugin. (cherry picked from commit 1440750)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We don’t really support it, so it’s very unlikely we’ll ever actually fix it.
Also, just disable it by default, because, again, we don’t really support it.
Test Plan
n/a
Additional Information
Closes: #17991 (but does not technically fix it).