[cleanup crusade] lint installer script #4164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktsaou
reviewed
Sep 12, 2018
|
|
||
| REINSTALL_PWD="${PWD}" | ||
| REINSTALL_COMMAND="$(printf "%q " "$0" "${@}"; printf "\n")" | ||
| REINSTALL_COMMAND="$(printf "%q " "$0" "${@}"; printf "\\n")" |
There was a problem hiding this comment.
You have added an extra backslash to \n. We just need a new line to be printed here, since printf does not print new lines.
There was a problem hiding this comment.
This will still be printing a newline. https://github.com/koalaman/shellcheck/wiki/SC1117
There was a problem hiding this comment.
This fix is "retired".... so they got it back.
There was a problem hiding this comment.
Looks like I am just using shellcheck 0.4.7 in which this is not retired.
ktsaou
reviewed
Sep 12, 2018
| @@ -176,30 +182,32 @@ get_git_config_signatures() { | |||
| local x s file md5 | |||
|
|
|||
| [ ! -d "conf.d" ] && echo >&2 "Wrong directory." && return 1 | |||
| [ -z "${md5sum}" -o ! -x "${md5sum}" ] && echo >&2 "No md5sum command." && return 1 | |||
| [ -z "${md5sum}" ] || [ ! -x "${md5sum}" ] && echo >&2 "No md5sum command." && return 1 | |||
There was a problem hiding this comment.
This may need parenthesis around the conditions.
ktsaou
reviewed
Sep 12, 2018
| while read | ||
| do | ||
| if [[ ! "${path}" =~ (^|:)"${REPLY}"(:|$) ]] | ||
| then | ||
| [ ! -z "${path}" ] && path="${path}:" | ||
| path="${path}${REPLY}" | ||
| fi | ||
| done < <( echo "${PATH}" | tr ":" "\n" ) | ||
| done < <( echo "${PATH}" | tr ":" "\\n" ) |
There was a problem hiding this comment.
ktsaou
reviewed
Sep 12, 2018
| @@ -489,7 +502,7 @@ run ./configure \ | |||
| --with-zlib \ | |||
| --with-math \ | |||
| --with-user=netdata \ | |||
| ${NETDATA_CONFIGURE_OPTIONS} \ | |||
| "${NETDATA_CONFIGURE_OPTIONS}" \ | |||
There was a problem hiding this comment.
This was intentionally without quotes; it contains one or more parameters to configure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran shellcheck and fix errors. Added some FIXME and disabled a couple of linter checks due to quite large portion of magic happening in this script.
We should probably think of some way of reducing size of this script as this is close to being unmaintainable by people other than an author.