Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go.d documentation #5215

Merged
merged 4 commits into from Feb 6, 2019
Merged

Add go.d documentation #5215

merged 4 commits into from Feb 6, 2019

Conversation

cakrit
Copy link
Contributor

@cakrit cakrit commented Jan 18, 2019

Summary

docs/generator/buildhtml.sh clones https://github.com/netdata/go.d.plugin.git under collectors and extracts the md files to build the static site.

Component Name

docs

@cakrit cakrit changed the title Add go.d documentation [WIP] Add go.d documentation Jan 22, 2019
@cakrit
Copy link
Contributor Author

cakrit commented Jan 22, 2019

The edit on the generated html site doesn't lead to the correct md file, I'll need to correct it.

@cakrit cakrit changed the title [WIP] Add go.d documentation Add go.d documentation Feb 6, 2019
@cakrit
Copy link
Contributor Author

cakrit commented Feb 6, 2019

Ready for review and merge. I should have done it before 1.12, but at least it only affects our docs site.
See the results in the netlify build, under data collection -> external collectors

@cakrit cakrit requested a review from ilyam8 February 6, 2019 09:46
@cakrit cakrit changed the title Add go.d documentation WIP - Add go.d documentation Feb 6, 2019
@cakrit
Copy link
Contributor Author

cakrit commented Feb 6, 2019

Hold on, I thought I had fixed the links but I didn't.

@cakrit cakrit changed the title WIP - Add go.d documentation Add go.d documentation Feb 6, 2019
@cakrit
Copy link
Contributor Author

cakrit commented Feb 6, 2019

Never mind, it was caching on my local machine. It's fine.

docs/generator/buildyaml.sh Outdated Show resolved Hide resolved
…'t work with the last sed, added rms to clean up the go.d cloned dir before and after execution
@cakrit cakrit merged commit d054de0 into netdata:master Feb 6, 2019
@cakrit cakrit deleted the demosite branch February 6, 2019 15:31
@cakrit cakrit added this to the v1.13-rc0 milestone Feb 14, 2019
kiku-jw pushed a commit to kiku-jw/netdata that referenced this pull request Mar 4, 2019
docs/generator/buildyaml.sh
* Modified menu structure of collectors
* Added go.d plugin

docs/generator/buildhtml.sh
* Added go.d documentation (git clone). Clean up the go.d cloned dir before and after execution
* Replace page edit links to github for go.d.plugin. Removed nomkdocs option which doesn't work with this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants