netdata/packaging/installer: netdata-installer.sh script (and subscripts) refactoring wrap-up #5736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctions to reduce levels of indirection
…tter code readability
…out/stderr, it may confuse our users The second commit was a follow up cleanup on nits.
paulkatsoulakis
added
area/packaging
added 7 commits
March 29, 2019 10:48
This reverts commit 6ee51cc. sorry, wrong repo
…f the helper method 1) rename to safe_pidof, which is actually more accurate and describe what this method serves for (safe pid detection) 2) Renaming it also avoids the bug introduced by the usage of , that resulted in endless nested calls of the BASH method pidif (Refer to command -v usage)
…ns in a different file for reuse
sourcing happens in a different way, follow that for system lib
This reverts commit 65d4b43. -- too mixed up, we can do later --
…operations in a different file for reuse" This reverts commit 227ee2f. -- too mixed up, we revise it later --
cakrit
approved these changes
Mar 29, 2019
|
issue #5705 has detailed the steps of testing that took place prior to this PR. Merging |
kazazes
added a commit
to SkyScraperAI/netdata
that referenced
this pull request
Apr 3, 2019
* Remove temp log file if no update needed (netdata#5695) * [ci skip] create nightly packages and update changelog * Add SMS Server Tools 3 SMS notifications (netdata#5662) * Add SMS Server Tools 3 SMS notifications * Minor reordering to present changes better * Fix typo in README link * Fix Codacy Missing code-language flag * Fix missing "to" in readme * Integrity testing: Check published kickstart files integrity (netdata#5689) * netdata/packaging/ci: Integrity testing Introduce a scriptlet that validates kickstart integrity in my-netdata.io against the ones in the repo. Run this through the pipeline on a scheduled manner. Will refine the conditionals later, once i verify the stage is built up as expected * netdata/packaging/ci: remove conditionals first * netdata/packaging/ci: Adjust the names to something more appropriate. Run it along with nightlies * netdata/packager/ci: Cleanup checksum validation for kickstart files (continued) 1) merge validate_kickstart_integrity.sh and tests/installer/checksums.sh 2) run checksums at the new point on the pipeline 3) Change that unstable gitignore check and use a more file-agnostic check that depends only on git that we already require 4) Do not run the kickstart validation on the online website everywhere, only on the nightly runs * netdata/packaging/ci: First rounf of PR feedback adjustments 1) changes wordings as recommended 2) pass file info in parameter and use it in the wordings 3) as shellcheck suggests, use -n instead of ! -z. Makes sense actually, ! -z is kind of reverse logic that confuses More adjustments on a follow up commit * netdata/packaging/ci: Enable slack integration for kickstart validation We want to be notified in a timely manner when the kickstart on the website is outdated. Added a wrapper for incoming webhooks from slack and instead of failing the build we notify slack Added a debug message in the end of the script to validate the process which i will remove on a follow up commit * netdata/packaging/ci: fixes fix sourcing path missed the /, this new keyboard is a pain :p * add 'containers priority' option to cgroups plugin (netdata#5700) * add 'containers priority' option to cgroups plugin * rename var to cgroup_containers_chart_priority * minor * [ci skip] create nightly packages and update changelog * postgres add ssl connection support (netdata#5661) * add ssl connection support * 9.1 is deprecated, use current doc * make sslmode mandatory if any other ssl option is set + minor * ssl params check fix * netdata/packaging/ci: nits (netdata#5709) It is approved by @cakrit, not sure why github doesn't let me merge it since he is code owner. We are still looking at this, merging for now as this is a really tiny and safe change anyway * add some kubernetes to apps_groups.conf (netdata#5714) ##### Summary Add kubernetes related processes to [apps_groups.conf](https://github.com/netdata/netdata/blob/master/collectors/apps.plugin/apps_groups.conf) ##### Component Name [/collectors/apps.plugin](https://github.com/netdata/netdata/tree/master/collectors/apps.plugin) ##### Additional Information * Add xenstat plugin (netdata#5660) * Add xenstat plugin * Add basic domain charts * Initialize xl context * Use domain UUID instead of name * Make charts obsolete * Add tmem charts * Change algorithm for tmem puts and gets * Add VCPU charts * Minor formatting for sending charts functions * Add VBD charts * Add network charts * Assemble VCPU metrics in one chart * Fix chart names * Make write/sent dimensions negative * Minor formatting * Change id and context for domain charts * Add dashboard info * Get rid of global variables * Free libxenstat and libxl resourses * Free domain_metrics on VM shutdown * Add domain state chart * Add debug messages * Add branch prediction hints * Minor fix * Fix chart obsoleting * Make names more general * Fix CMake build of nfacct.plugin * Update fping version (netdata#5719) * Send custom docs (netdata#5703) * Improve custom notifications documentation * Updated main README with link to custom * Fix lists for HTML generation * Another effort to fix the lists * [ci skip] create nightly packages and update changelog * Fix dist build (netdata#5728) This is an exceptional situation, we need this emergent PR to fix our pipeline * [ci skip] create nightly packages and update changelog * Spelling fix for streaming readme.md (netdata#5734) * add some kubelet alarms (netdata#5724) ##### Summary Add some alarms for kubelet module from netdata#5720 ##### Component Name [/health/health.d](https://github.com/netdata/netdata/tree/master/health/health.d) * NEW: authdb option for MongoDB collector (netdata#5707) * NEW: authdb option for MongoDB collector * Extended mongodb.conf example with authdb option * Commented out secure example in mongodb.conf * FIXED: mongodb changes to be compatible with pre-Py2.4 * installer: include go.d.plugin version v0.3.1 (netdata#5740) ##### Summary ssia ##### Component Name go.d.plugin * netdata/packaging/installer: netdata-installer.sh script (and subscripts) refactoring wrap-up (netdata#5736) * remove dead quickfix * unify global variable naming * do not use double negation * simplify setcap detection * simplify logic of setting capabilities to apps.plugin * always set group in chown * simplify parameter parsing and banner notifications * use built-in command for checking program availability * lint functions.sh * fix errors returned by shellcheck * remove unused functions and use portable_service * move user management functions closer together and remove "check" functions to reduce levels of indirection * extract add_netdata_user_and_group and move it into installers for better code readability * improve readability by not using global variable holding number of processors * move netdata.conf file creation into one function * revert migration to portable_service * Less verbose setcap * remove TODOs * do not show output when not needed * fix checking for group existence * fix variable name * netdata/packaging/installer: Dont spill out unnecessary output in stdout/stderr, it may confuse our users The second commit was a follow up cleanup on nits. * access: change codeowner * Revert "access: change codeowner" This reverts commit 6ee51cc. sorry, wrong repo * netdata/packaging/installer: bug fix - do not use pidof as the name of the helper method 1) rename to safe_pidof, which is actually more accurate and describe what this method serves for (safe pid detection) 2) Renaming it also avoids the bug introduced by the usage of , that resulted in endless nested calls of the BASH method pidif (Refer to command -v usage) * netdata/packaging/ci: Make Travis CI more strict on nightlies run (netdata#5708) * netdata/packaging/ci: Make nightlies fail hard on all errors except changelog (netdata#5580) 1) Add the necessary comments for documentation 2) Reinstate set -e to fail hard on errors 3) When changelog generation fails, just report a log entry and continue so that we dont break the release These changes are temporary, we are following up with more aggressive changes that re-distribute processing * netdata/packaging/nightlies: Clean up nightlies, round one of many 1) Move ALL changelog generation related code, to generate changelog script 2) Remove that || logic from everywherem, except the part we execute changelog generation. We have said its optional, so do not fail nightlies if this script fails, just report the problem 3) change the gitignore change and use the more stable logic that monitors folder path utilizing git 4) Add a bit more verbosity everywhere so we can tell what is going on 5) Adjust generate changelog script, based on the newly migrated code. a) Variable declarations to the top, so that if something wrong with the generated ones we break early and avoid the mess b) put all that github handling, right after markmandel's changelog generation c) Gently handle github commands, add enough verbosity to identify where we broke and also check in the end what happened and clean-up github before you bail out 6) A couple of renames for variables here and there, for clarity and readability * netdata/packaging/ci: nits and fixes 1) Make sure nightlies still dont run when no changes are seen since last nightly 2) Artifacts creation should happen even if docker breaks. Ensure that and on the next iteration we will restructure the pipeline to a more productive layout 3) settle a couple of shellcheck warnings * netdata/packaging/docker: build and publish are using a BASH v4 capability. Make sure you break early with a message if we ever run on a different bash by accident * access: fix codeowners (netdata#5739) * [ci skip] create nightly packages and update changelog * netdata/packaging/makeself: no comment, i will be adding artifact emulation on the builds, not just make dist ^_^ (netdata#5743) * [ci skip] create nightly packages and update changelog * netdata/packaging/ci: small improvements in logging (netdata#5746) * netdata/packaging/ci: calculate the version string earlier, so that we can have it in our logs for troubleshooting. Also a small comment nit * netdata/packaging/ci: always use curlies * [netdata release candidate] Release candidate v1.13.0-rc0 * [netdata release candidate] Release candidate v1.14.0-rc0 (repeat with correct comment) * [ci skip] create nightly packages and update changelog * [ci skip] Emergency fix for travis pipeline - reinstate pre-optimized changelog generator, to fit in releaser until we properly redesign the process * [netdata release candidate] Release candidate v1.14.0-rc0 * [ci skip] release v1.14.0-rc0 * [ci skip] create nightly packages and update changelog * fix checksum (netdata#5750) * Fix some misspells in docs and code (netdata#5549) Signed-off-by: zhoulin xie <zhoulin.xie@daocloud.io> * [ci skip] create nightly packages and update changelog * postgres module: connect via uri (netdata#5758) * add connection via URI support * update config * update readme * change link * libapache2-mod-proxy-html was a transitional package for apache2-bin (netdata#5753) Since the translation is completed it should be already included in the apache2-bin Xenial package. In fact you can find the mod_proxy_html.so file in the apache2-bin file list (Xenial). Source: https://stackoverflow.com/a/40263887 * Fix the Polyverse reinstall that caused APK broken state (netdata#5751) * Fix py2-psycopg2 right after upgrade This mitigates the issue netdata#5588 * Improve reinstall script so it doesn't get into broken state * Update and upgrade before polymorphic linux * apk fix py2-psycopg2 right after reinstall. * Removing apk fix - package is now blacklisted upstream * netdata/packaging/installer: fix sha256sum failure on freeBSD (netdata#5760) * netdata/packaging/installer: Introduce safe_sha256sum - a more flexible checsum function Due to netdata#5747 we discovered that our installer wasnt working properly on FreeBSD. We created within our functions lib a safe_sha256sum that picks between sha256sum and shasum, with priority to the first method * netdata/packaging/installer: Update checksums in README * Correct typo in ceph README (netdata#5742) * Added RocketChat default recipient for roles (netdata#5545) * Added rocketchat to method-list * Added role to default_recipient_rocketchat mapping * Updated to role_recipients_rocketchat * Add simonnagl as CODEOWNER for cups.plugin (netdata#5453) * Fix typo in CODEOWNERS user paufantom does not exist. * Add simonnagl as codeowner for cups.plugin * [ci skip] create nightly packages and update changelog * Make netdata.spec more futureproof (netdata#5766) * netdata/packaging/kickstart: fix kickstart (netdata#5771) * netdata/packaging/kickstart: import the newly created safe_sha256sum() bash function * netdata/packaging: add new md5sums * netdata/packaging: Remove .tar.gz on distclean (netdata#5763) * netdata/packaging: Remove .tar.gz on distclean * netdata/packaging: Do not use pattern, there is dist variable to point to the specific file to delete upon clean * Fix smstools3 error handling (netdata#5770) * Fixed smstools3 error handling * Correct variable declarations * Correct smssend to sendsms * Add two spaces before dashes in .md lists * Add two spaces AFTER dashes in .md lists * Change list to star * netdata: Add another global owner (netdata#5777) * netdata/packaging/ci: Add kickstart execution integrity tests (netdata#5778) * netdata/packaging/ci: Add integrity tests for kickstart scripts * netdata/packaging/ci: Add a parallelized step to validate each build against kickstart - totally worth it * netdata/packaging/ci: re-trigger travis with an empty commit * netdata/packaging/ci: fix travis syntax (netdata#5780) * netdata/packaging/ci: fix travis syntax * netdata/packaging/ci: fix testing for static64 * [ci skip] create nightly packages and update changelog * netdata/packaging/updater: fix updater (netdata#5785) * [ci skip] create nightly packages and update changelog * Fix unix socket access on FreeBSD (netdata#5756)
kazazes
added a commit
to SkyScraperAI/netdata
that referenced
this pull request
Aug 16, 2019
* Remove temp log file if no update needed (netdata#5695) * [ci skip] create nightly packages and update changelog * Add SMS Server Tools 3 SMS notifications (netdata#5662) * Add SMS Server Tools 3 SMS notifications * Minor reordering to present changes better * Fix typo in README link * Fix Codacy Missing code-language flag * Fix missing "to" in readme * Integrity testing: Check published kickstart files integrity (netdata#5689) * netdata/packaging/ci: Integrity testing Introduce a scriptlet that validates kickstart integrity in my-netdata.io against the ones in the repo. Run this through the pipeline on a scheduled manner. Will refine the conditionals later, once i verify the stage is built up as expected * netdata/packaging/ci: remove conditionals first * netdata/packaging/ci: Adjust the names to something more appropriate. Run it along with nightlies * netdata/packager/ci: Cleanup checksum validation for kickstart files (continued) 1) merge validate_kickstart_integrity.sh and tests/installer/checksums.sh 2) run checksums at the new point on the pipeline 3) Change that unstable gitignore check and use a more file-agnostic check that depends only on git that we already require 4) Do not run the kickstart validation on the online website everywhere, only on the nightly runs * netdata/packaging/ci: First rounf of PR feedback adjustments 1) changes wordings as recommended 2) pass file info in parameter and use it in the wordings 3) as shellcheck suggests, use -n instead of ! -z. Makes sense actually, ! -z is kind of reverse logic that confuses More adjustments on a follow up commit * netdata/packaging/ci: Enable slack integration for kickstart validation We want to be notified in a timely manner when the kickstart on the website is outdated. Added a wrapper for incoming webhooks from slack and instead of failing the build we notify slack Added a debug message in the end of the script to validate the process which i will remove on a follow up commit * netdata/packaging/ci: fixes fix sourcing path missed the /, this new keyboard is a pain :p * add 'containers priority' option to cgroups plugin (netdata#5700) * add 'containers priority' option to cgroups plugin * rename var to cgroup_containers_chart_priority * minor * [ci skip] create nightly packages and update changelog * postgres add ssl connection support (netdata#5661) * add ssl connection support * 9.1 is deprecated, use current doc * make sslmode mandatory if any other ssl option is set + minor * ssl params check fix * netdata/packaging/ci: nits (netdata#5709) It is approved by @cakrit, not sure why github doesn't let me merge it since he is code owner. We are still looking at this, merging for now as this is a really tiny and safe change anyway * add some kubernetes to apps_groups.conf (netdata#5714) ##### Summary Add kubernetes related processes to [apps_groups.conf](https://github.com/netdata/netdata/blob/master/collectors/apps.plugin/apps_groups.conf) ##### Component Name [/collectors/apps.plugin](https://github.com/netdata/netdata/tree/master/collectors/apps.plugin) ##### Additional Information * Add xenstat plugin (netdata#5660) * Add xenstat plugin * Add basic domain charts * Initialize xl context * Use domain UUID instead of name * Make charts obsolete * Add tmem charts * Change algorithm for tmem puts and gets * Add VCPU charts * Minor formatting for sending charts functions * Add VBD charts * Add network charts * Assemble VCPU metrics in one chart * Fix chart names * Make write/sent dimensions negative * Minor formatting * Change id and context for domain charts * Add dashboard info * Get rid of global variables * Free libxenstat and libxl resourses * Free domain_metrics on VM shutdown * Add domain state chart * Add debug messages * Add branch prediction hints * Minor fix * Fix chart obsoleting * Make names more general * Fix CMake build of nfacct.plugin * Update fping version (netdata#5719) * Send custom docs (netdata#5703) * Improve custom notifications documentation * Updated main README with link to custom * Fix lists for HTML generation * Another effort to fix the lists * [ci skip] create nightly packages and update changelog * Fix dist build (netdata#5728) This is an exceptional situation, we need this emergent PR to fix our pipeline * [ci skip] create nightly packages and update changelog * Spelling fix for streaming readme.md (netdata#5734) * add some kubelet alarms (netdata#5724) ##### Summary Add some alarms for kubelet module from netdata#5720 ##### Component Name [/health/health.d](https://github.com/netdata/netdata/tree/master/health/health.d) * NEW: authdb option for MongoDB collector (netdata#5707) * NEW: authdb option for MongoDB collector * Extended mongodb.conf example with authdb option * Commented out secure example in mongodb.conf * FIXED: mongodb changes to be compatible with pre-Py2.4 * installer: include go.d.plugin version v0.3.1 (netdata#5740) ##### Summary ssia ##### Component Name go.d.plugin * netdata/packaging/installer: netdata-installer.sh script (and subscripts) refactoring wrap-up (netdata#5736) * remove dead quickfix * unify global variable naming * do not use double negation * simplify setcap detection * simplify logic of setting capabilities to apps.plugin * always set group in chown * simplify parameter parsing and banner notifications * use built-in command for checking program availability * lint functions.sh * fix errors returned by shellcheck * remove unused functions and use portable_service * move user management functions closer together and remove "check" functions to reduce levels of indirection * extract add_netdata_user_and_group and move it into installers for better code readability * improve readability by not using global variable holding number of processors * move netdata.conf file creation into one function * revert migration to portable_service * Less verbose setcap * remove TODOs * do not show output when not needed * fix checking for group existence * fix variable name * netdata/packaging/installer: Dont spill out unnecessary output in stdout/stderr, it may confuse our users The second commit was a follow up cleanup on nits. * access: change codeowner * Revert "access: change codeowner" This reverts commit 6ee51cc. sorry, wrong repo * netdata/packaging/installer: bug fix - do not use pidof as the name of the helper method 1) rename to safe_pidof, which is actually more accurate and describe what this method serves for (safe pid detection) 2) Renaming it also avoids the bug introduced by the usage of , that resulted in endless nested calls of the BASH method pidif (Refer to command -v usage) * netdata/packaging/ci: Make Travis CI more strict on nightlies run (netdata#5708) * netdata/packaging/ci: Make nightlies fail hard on all errors except changelog (netdata#5580) 1) Add the necessary comments for documentation 2) Reinstate set -e to fail hard on errors 3) When changelog generation fails, just report a log entry and continue so that we dont break the release These changes are temporary, we are following up with more aggressive changes that re-distribute processing * netdata/packaging/nightlies: Clean up nightlies, round one of many 1) Move ALL changelog generation related code, to generate changelog script 2) Remove that || logic from everywherem, except the part we execute changelog generation. We have said its optional, so do not fail nightlies if this script fails, just report the problem 3) change the gitignore change and use the more stable logic that monitors folder path utilizing git 4) Add a bit more verbosity everywhere so we can tell what is going on 5) Adjust generate changelog script, based on the newly migrated code. a) Variable declarations to the top, so that if something wrong with the generated ones we break early and avoid the mess b) put all that github handling, right after markmandel's changelog generation c) Gently handle github commands, add enough verbosity to identify where we broke and also check in the end what happened and clean-up github before you bail out 6) A couple of renames for variables here and there, for clarity and readability * netdata/packaging/ci: nits and fixes 1) Make sure nightlies still dont run when no changes are seen since last nightly 2) Artifacts creation should happen even if docker breaks. Ensure that and on the next iteration we will restructure the pipeline to a more productive layout 3) settle a couple of shellcheck warnings * netdata/packaging/docker: build and publish are using a BASH v4 capability. Make sure you break early with a message if we ever run on a different bash by accident * access: fix codeowners (netdata#5739) * [ci skip] create nightly packages and update changelog * netdata/packaging/makeself: no comment, i will be adding artifact emulation on the builds, not just make dist ^_^ (netdata#5743) * [ci skip] create nightly packages and update changelog * netdata/packaging/ci: small improvements in logging (netdata#5746) * netdata/packaging/ci: calculate the version string earlier, so that we can have it in our logs for troubleshooting. Also a small comment nit * netdata/packaging/ci: always use curlies * [netdata release candidate] Release candidate v1.13.0-rc0 * [netdata release candidate] Release candidate v1.14.0-rc0 (repeat with correct comment) * [ci skip] create nightly packages and update changelog * [ci skip] Emergency fix for travis pipeline - reinstate pre-optimized changelog generator, to fit in releaser until we properly redesign the process * [netdata release candidate] Release candidate v1.14.0-rc0 * [ci skip] release v1.14.0-rc0 * [ci skip] create nightly packages and update changelog * fix checksum (netdata#5750) * Fix some misspells in docs and code (netdata#5549) Signed-off-by: zhoulin xie <zhoulin.xie@daocloud.io> * [ci skip] create nightly packages and update changelog * postgres module: connect via uri (netdata#5758) * add connection via URI support * update config * update readme * change link * libapache2-mod-proxy-html was a transitional package for apache2-bin (netdata#5753) Since the translation is completed it should be already included in the apache2-bin Xenial package. In fact you can find the mod_proxy_html.so file in the apache2-bin file list (Xenial). Source: https://stackoverflow.com/a/40263887 * Fix the Polyverse reinstall that caused APK broken state (netdata#5751) * Fix py2-psycopg2 right after upgrade This mitigates the issue netdata#5588 * Improve reinstall script so it doesn't get into broken state * Update and upgrade before polymorphic linux * apk fix py2-psycopg2 right after reinstall. * Removing apk fix - package is now blacklisted upstream * netdata/packaging/installer: fix sha256sum failure on freeBSD (netdata#5760) * netdata/packaging/installer: Introduce safe_sha256sum - a more flexible checsum function Due to netdata#5747 we discovered that our installer wasnt working properly on FreeBSD. We created within our functions lib a safe_sha256sum that picks between sha256sum and shasum, with priority to the first method * netdata/packaging/installer: Update checksums in README * Correct typo in ceph README (netdata#5742) * Added RocketChat default recipient for roles (netdata#5545) * Added rocketchat to method-list * Added role to default_recipient_rocketchat mapping * Updated to role_recipients_rocketchat * Add simonnagl as CODEOWNER for cups.plugin (netdata#5453) * Fix typo in CODEOWNERS user paufantom does not exist. * Add simonnagl as codeowner for cups.plugin * [ci skip] create nightly packages and update changelog * Make netdata.spec more futureproof (netdata#5766) * netdata/packaging/kickstart: fix kickstart (netdata#5771) * netdata/packaging/kickstart: import the newly created safe_sha256sum() bash function * netdata/packaging: add new md5sums * netdata/packaging: Remove .tar.gz on distclean (netdata#5763) * netdata/packaging: Remove .tar.gz on distclean * netdata/packaging: Do not use pattern, there is dist variable to point to the specific file to delete upon clean * Fix smstools3 error handling (netdata#5770) * Fixed smstools3 error handling * Correct variable declarations * Correct smssend to sendsms * Add two spaces before dashes in .md lists * Add two spaces AFTER dashes in .md lists * Change list to star * netdata: Add another global owner (netdata#5777) * netdata/packaging/ci: Add kickstart execution integrity tests (netdata#5778) * netdata/packaging/ci: Add integrity tests for kickstart scripts * netdata/packaging/ci: Add a parallelized step to validate each build against kickstart - totally worth it * netdata/packaging/ci: re-trigger travis with an empty commit * netdata/packaging/ci: fix travis syntax (netdata#5780) * netdata/packaging/ci: fix travis syntax * netdata/packaging/ci: fix testing for static64 * [ci skip] create nightly packages and update changelog * netdata/packaging/updater: fix updater (netdata#5785) * [ci skip] create nightly packages and update changelog * Fix unix socket access on FreeBSD (netdata#5756)
jackyhuang85
pushed a commit
to jackyhuang85/netdata
that referenced
this pull request
Jan 1, 2020
…pts) refactoring wrap-up (netdata#5736) * remove dead quickfix * unify global variable naming * do not use double negation * simplify setcap detection * simplify logic of setting capabilities to apps.plugin * always set group in chown * simplify parameter parsing and banner notifications * use built-in command for checking program availability * lint functions.sh * fix errors returned by shellcheck * remove unused functions and use portable_service * move user management functions closer together and remove "check" functions to reduce levels of indirection * extract add_netdata_user_and_group and move it into installers for better code readability * improve readability by not using global variable holding number of processors * move netdata.conf file creation into one function * revert migration to portable_service * Less verbose setcap * remove TODOs * do not show output when not needed * fix checking for group existence * fix variable name * netdata/packaging/installer: Dont spill out unnecessary output in stdout/stderr, it may confuse our users The second commit was a follow up cleanup on nits. * access: change codeowner * Revert "access: change codeowner" This reverts commit 6ee51cc. sorry, wrong repo * netdata/packaging/installer: bug fix - do not use pidof as the name of the helper method 1) rename to safe_pidof, which is actually more accurate and describe what this method serves for (safe pid detection) 2) Renaming it also avoids the bug introduced by the usage of , that resulted in endless nested calls of the BASH method pidif (Refer to command -v usage)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR from issue #5705 that is the wrap up of PR #5505 from Pawel.
It only includes some small changes on top of the ones that Pawel had already fixed from the feedback of #5505.
Please follow up the testing that took place on #5705 and give any further feedback on other issues you spot
Component Name
netdata/packaging/installer
Additional Information
None