NEW: Energi Core daemon monitoring, suits other Bitcoin forks #5894
Conversation
andvgal
requested review from
cakrit,
ilyam8,
ktsaou and
paulkatsoulakis
as code owners
|
@Ferroin It is part of energid.conf, but OK. It can be added there. Maybe you know how to run Codacy Markdown checks locally then? |
|
Regarding the Codacy checks, I'm not sure of any way to run them locally, but in this case the only issue I see is the indentation of the nested list items (Markdown technically requires two or more spaces of indentation for each nesting level), so just fixing that should clear up the checks. My suggestion would be to just use 4 spaces there instead of 2 like Codacy is suggesting, as that will make it consistent with the other documentation. |
|
Well, it was 4 spaces originally, but Codacy did not like that either. Tried to copy list style from other modules. Could it be they are just broken and not shown in PR checks...? |
|
That's interesting. Without any changes to the Markdown list, Codacy accepted it from the third time, |
Sounds like a bug on Codacy's side to me. |
netdatabot
added
area/collectors
andvgal
changed the title
|
Well, Codacy markdown behaves strange... |
|
Codacy is passed, but it shows "changes requested" with no obvious items left. |
collectors/python.d.plugin/python_modules/bases/FrameworkServices/UrlService.py
Outdated
Show resolved
Hide resolved
|
Yeah... It seems Codacy Markdown got conquered. Looks like, the root cause of tons of misleading errors was broken bold notation in one of the list items. EDIT: no, it also a very strange behavior. It shows "Passed" and then changes to fail after some time. |
|
OK, it was absolutely not obvious and many other READMEs fail Markdown check. I'll submit a separate PR with |
|
OK...
|
|
thanks @andvgal ! |
…a#5894) * NEW: Energi Core daemon monitoring, suites other Bitcoin forks * Attempt to make Codacy checks happy * Added energid sample configuration, enabled by default * Post-review fixes & revised charts * Added default Energi, Bitcoin and Dash to energid.conf configuration * Fighting with Codacy markdown check * Added energid protocol description comment * Added JSON_RPC_VERSION as module variable * Screw you Codacy markdown * Screw you Codacy Markdown #2 * Screw you Codacy Markdown #3 * Finally, fixed what remark-lint wants * Strict local remark-lint + plugins pass for README.md * Attempt with another remark-lint configuration
…a#5894) * NEW: Energi Core daemon monitoring, suites other Bitcoin forks * Attempt to make Codacy checks happy * Added energid sample configuration, enabled by default * Post-review fixes & revised charts * Added default Energi, Bitcoin and Dash to energid.conf configuration * Fighting with Codacy markdown check * Added energid protocol description comment * Added JSON_RPC_VERSION as module variable * Screw you Codacy markdown * Screw you Codacy Markdown netdata#2 * Screw you Codacy Markdown netdata#3 * Finally, fixed what remark-lint wants * Strict local remark-lint + plugins pass for README.md * Attempt with another remark-lint configuration
Summary
Adds monitoring of Energi Core Bitcoin-derived daemon monitoring. It is named after the contributing cryptocurrency team, but targets a wide range of projects.
As there is no strict RPC standardization, there is no 100% guarantee that it will work with other forks of Bitcoin. Although, most of them should be supported and can be used with this plugin.
Component Name
New Python collector module.
Additional Information
Smoke tested with
make dist.Depends on #5893
Ignore
UrlServicechanged here.