SSL vs. TLS consistency and clarification in documentation #6414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlvkobal
reviewed
Jul 9, 2019
|
I'll approve when @vlvkobal and @thiagoftsm approve. |
thiagoftsm
requested changes
Jul 10, 2019
There was a problem hiding this comment.
Hi @joelhans , please, can you change the sentence "OpenTDSB does not by default support encrypted connections," to "OpenTDSB does not support encrypted connections,", because the previous sentence is given the idea that it is possible to configure OpenTSDB direct with support to TLS.
|
@thiagoftsm: Fixed that sentence you requested! |
thiagoftsm
approved these changes
Jul 10, 2019
cakrit
approved these changes
Jul 10, 2019
jackyhuang85
pushed a commit
to jackyhuang85/netdata
that referenced
this pull request
Jan 1, 2020
) * Changed references of SSL to TLS where appropriate * A few more tweaks on SSL->TLS * Fixed whitespace issue from @vlvkobal * Fixing sentence on OpenTSDB for @thiagoftsm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With TLS landing in the stable v1.16.0 release I wanted to make sure that we're being clear and as consistent as possible about the fact that we're using TLS 1.2 as the encryption protocol, not any of the obsolete SSL protocols.
The fact that "SSL" is colloquially used to refer to any encrypted web connection—it's kind of like "Kleenex" being used for any brand of tissue—complicates this a bit. In certain places I try to ease the transition with
TLS/SSL, but in my opinion we should be consistent in usingTLSwhenever possible, as that is technically correct.Component Name
docs
Additional Information
I've also included some grammatical/stylistic fixes to the areas relevant to TLS.
In an ideal world, any references in configuration files are changed from
ssltotls, but that's probably a huge project without any real value for the user. For example: