New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update stream documentation bringing explanation of some errors #6995
Conversation
Update documentation for stream to clarify the users some errors
Manage this branch in SquashTest this branch here: https://thiagoftsmstream-doc-7iejc.squash.io |
Explain more errors that can happen on master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joelhans please review and improve the text. There's several parts that could use some English-language love. Thanks!
streaming/README.md
Outdated
|
||
### Connection between slave and master is slow | ||
|
||
When we have a slow connection between master and `slave`, Netdata can raise different errors related to this problem, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are going to use backticks for slave, you might as well use them for master too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the beginning I was writing backticks to call attention of the people for both master and slave, but when I began to review I saw that this was not a pattern, after this I began to remove, but I forgot this one. Thank you!
streaming/README.md
Outdated
|
||
where the value X, Y, Z and W are integer numbers. | ||
|
||
in the master side the we can have different reports when the master reads everything from the stream and it did not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capitalize.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the error, thank you again!
I have a feeling that the correct solution is to make errors clear and descriptive. In that case we dont need to maintain page with errors explanations and keep it up to date. @thiagoftsm think about it. Just a suggestion. |
This commit fixes errors reported by @cosmix
This commit brings more fixes for the text and description for more errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some requests here and one question about the nature of the error.
This commit brings all the fixes suggested by Joel
This commit brings the last fix suggested by Joel
I missed a message format in the previous sprint
The previous explanation for these two features were not good enough, so I rewrite it to avoid confusion
After to receive the text from Joel, I am bringing all the fix for the new section on documentation
Thank you very much @joelhans ! Best regards! |
I've just worked through this myself to setup a streaming configuration for testing. It seems that there is something missing in the documentation, which is why so many people are struggling when they go through it for the first time. It could be improved with a howto / walkthrough for a minimal example at the top of the document. Something like:
It should show exactly what to type to achieve this setup, and not involve any decisions (i.e. pick all the options to be reasonable for a first-time setup). Once a user is over the hurdle of getting it working for the first-time the rest of the document works well as reference material:
There is currently a forward-reference in the text to the ephemeral nodes section as an example, but it is not simple enough to act as an initial guide and it does not drop down to a step-by-step level of detail showing exactly what to type. |
Hi @amoss , It was good you write here about the fact our documentation is not clear in some subjects, because we are working to bring Netdata Learning and this is an important characteristic for we work there. @joelhans , please, pay attention in @amoss words for all the course. Master: uuidgen
dfc307cc-9b7f-487d-86f5-349199f06004 2 - now it is time to edit your stream.conf: /etc/netdata/edit-config stream.conf 3 - Finally set the following variables:
Now it is necessary to configure your Slave: /etc/netdata/edit-config stream.conf 5 - On Slave we work in a different section:
The steps for the next slaves are exactly the same. Let us know whether this steps are helping, because they will help @joelhans and I move in front with documentation and Netdata learning. |
Yes, this is good. I think it works well as a walk-through and clarifies what to do. |
Thank you for the feedback! :) |
Why is this still open? Is there anything more to do on this PR before it gets accepted? |
We are missing reviews, there is not any necessity to add more info in this PR. |
@joelhans plz review again, it looks good from my side. |
…ata#6995) * stream_doc: Update documentation Update documentation for stream to clarify the users some errors * stream_doc: Update documentation 2 Explain more errors that can happen on master * Fix errors reported This commit fixes errors reported by @cosmix * Fix and more errors This commit brings more fixes for the text and description for more errors * stream_doc: Gramatical fixes This commit brings all the fixes suggested by Joel * stream_doc: Gramatical fixes This commit brings the last fix suggested by Joel * stream_doc: Message format I missed a message format in the previous sprint * Fix doc: This commit fix the errors reported by Joel * Fix test This commit brings part of the fixes requested from Christopher * New explanation: The previous explanation for these two features were not good enough, so I rewrite it to avoid confusion * stream_doc: Fix text After to receive the text from Joel, I am bringing all the fix for the new section on documentation
Summary
Fixes #6946
We are having reports from users about "bugs" in Netdata stream, but while we were helping them we are are verifying that the majority of these errors are bad configuration, this PR has the goal to clarify for the user possible errors in the stream.
Component Name
Stream documentation
Additional Information