New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user information to MySQL Python module documentation #7128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manage this branch in SquashTest this branch here: https://prhomhysemysql-doc-7f5fm.squash.io |
joelhans
suggested changes
Oct 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Just a few things to clean up.
Co-Authored-By: Joel Hans <joel.g.hans@gmail.com>
Co-Authored-By: Joel Hans <joel.g.hans@gmail.com>
Co-Authored-By: Joel Hans <joel.g.hans@gmail.com>
Co-Authored-By: Joel Hans <joel.g.hans@gmail.com>
ilyam8
reviewed
Oct 18, 2019
joelhans
approved these changes
Oct 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now!
ilyam8
approved these changes
Oct 24, 2019
jackyhuang85
pushed a commit
to jackyhuang85/netdata
that referenced
this pull request
Jan 1, 2020
* add user details to MySQL py module doc * Update collectors/python.d.plugin/mysql/README.md Co-Authored-By: Joel Hans <joel.g.hans@gmail.com> * Grammar fixes Co-Authored-By: Joel Hans <joel.g.hans@gmail.com> * suggested changes Co-Authored-By: Joel Hans <joel.g.hans@gmail.com> * suggested changes Co-Authored-By: Joel Hans <joel.g.hans@gmail.com> * add mysql shell
Saruspete
pushed a commit
to Saruspete/netdata
that referenced
this pull request
May 21, 2020
* add user details to MySQL py module doc * Update collectors/python.d.plugin/mysql/README.md Co-Authored-By: Joel Hans <joel.g.hans@gmail.com> * Grammar fixes Co-Authored-By: Joel Hans <joel.g.hans@gmail.com> * suggested changes Co-Authored-By: Joel Hans <joel.g.hans@gmail.com> * suggested changes Co-Authored-By: Joel Hans <joel.g.hans@gmail.com> * add mysql shell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to: #7126
It is not stated in the documentation that
netdata
MySQL user has to be created for the MySQL charts to show on the dashboard.Component Name
docs
Additional Information