Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user information to MySQL Python module documentation #7128

Merged
merged 6 commits into from Oct 24, 2019
Merged

Add user information to MySQL Python module documentation #7128

merged 6 commits into from Oct 24, 2019

Conversation

prhomhyse
Copy link
Contributor

Summary

Related to: #7126

It is not stated in the documentation that netdata MySQL user has to be created for the MySQL charts to show on the dashboard.

Component Name

docs

Additional Information

@squash-labs
Copy link

squash-labs bot commented Oct 18, 2019

Manage this branch in Squash

Test this branch here: https://prhomhysemysql-doc-7f5fm.squash.io

Copy link
Contributor

@joelhans joelhans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Just a few things to clean up.

collectors/python.d.plugin/mysql/README.md Outdated Show resolved Hide resolved
collectors/python.d.plugin/mysql/README.md Outdated Show resolved Hide resolved
collectors/python.d.plugin/mysql/README.md Outdated Show resolved Hide resolved
collectors/python.d.plugin/mysql/README.md Outdated Show resolved Hide resolved
prhomhyse and others added 4 commits October 18, 2019 17:58
Co-Authored-By: Joel Hans <joel.g.hans@gmail.com>
Co-Authored-By: Joel Hans <joel.g.hans@gmail.com>
Co-Authored-By: Joel Hans <joel.g.hans@gmail.com>
Co-Authored-By: Joel Hans <joel.g.hans@gmail.com>
Copy link
Contributor

@joelhans joelhans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now!

@ilyam8 ilyam8 merged commit a6229b2 into netdata:master Oct 24, 2019
jackyhuang85 pushed a commit to jackyhuang85/netdata that referenced this pull request Jan 1, 2020
* add user details to MySQL py module doc

* Update collectors/python.d.plugin/mysql/README.md

Co-Authored-By: Joel Hans <joel.g.hans@gmail.com>

* Grammar fixes

Co-Authored-By: Joel Hans <joel.g.hans@gmail.com>

* suggested changes

Co-Authored-By: Joel Hans <joel.g.hans@gmail.com>

* suggested changes

Co-Authored-By: Joel Hans <joel.g.hans@gmail.com>

* add mysql shell
Saruspete pushed a commit to Saruspete/netdata that referenced this pull request May 21, 2020
* add user details to MySQL py module doc

* Update collectors/python.d.plugin/mysql/README.md

Co-Authored-By: Joel Hans <joel.g.hans@gmail.com>

* Grammar fixes

Co-Authored-By: Joel Hans <joel.g.hans@gmail.com>

* suggested changes

Co-Authored-By: Joel Hans <joel.g.hans@gmail.com>

* suggested changes

Co-Authored-By: Joel Hans <joel.g.hans@gmail.com>

* add mysql shell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants