Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.travis.yml: Increase timeout for docker image builds to 20 minutes #7214

Merged
merged 1 commit into from Oct 30, 2019
Merged

.travis.yml: Increase timeout for docker image builds to 20 minutes #7214

merged 1 commit into from Oct 30, 2019

Conversation

knatsakis
Copy link
Contributor

Summary

Increase the timeout for docker image builds to 20 minutes

Component Name

.travis.yml

Additional Information

Fixes #7213

@knatsakis knatsakis added area/ci area/packaging Packaging and operating systems support labels Oct 28, 2019
@squash-labs
Copy link

squash-labs bot commented Oct 28, 2019

Manage this branch in Squash

Test this branch here: https://knatsakis7213-fix-nightlies-ti-0wmbp.squash.io

@knatsakis
Copy link
Contributor Author

Test build

@knatsakis
Copy link
Contributor Author

Success output:
https://travis-ci.org/knatsakis/netdata/jobs/604169082#L461

Failure output:
https://travis-ci.org/knatsakis/netdata/jobs/604169083#L462

@netdatabot netdatabot removed the area/packaging Packaging and operating systems support label Oct 29, 2019
@cosmix
Copy link
Contributor

cosmix commented Oct 29, 2019

Hardcoded time-based sleepy/wait` solutions are seldom good. Approving so that we can fix the nightlies, but you should ideally use a more robust mechanism to do this.

fracasula
fracasula approved these changes Oct 30, 2019
View reviewed changes
Copy link

@fracasula fracasula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@knatsakis knatsakis merged commit 3fde052 into netdata:master Oct 30, 2019
@knatsakis knatsakis deleted the 7213-fix-nightlies-timeout branch October 30, 2019 09:59
jackyhuang85 pushed a commit to jackyhuang85/netdata that referenced this pull request Jan 1, 2020
@knatsakis @jackyhuang85
.travis.yml: Increase timeout for docker image builds to 20 minutes (n…
0eeaee4 
…etdata#7214)
Saruspete pushed a commit to Saruspete/netdata that referenced this pull request May 21, 2020
@knatsakis @Saruspete
.travis.yml: Increase timeout for docker image builds to 20 minutes (n…
c81ae2d 
…etdata#7214)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosmix cosmix cosmix approved these changes

@fracasula fracasula fracasula approved these changes

@cakrit cakrit Awaiting requested review from cakrit

Assignees
No one assigned
Labels
area/ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nigthlies are failing due to timeout
4 participants
@knatsakis @cosmix @fracasula @netdatabot