fix_irc_notification: Remove line break from message #7243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The line break present on netdata alarms are creating 421 errors on the server, this is happening because according RFC1459 this is the end of the message
Manage this branch in SquashTest this branch here: https://thiagoftsmfix-irc-notification-wytca.squash.io |
the script 'alarm-notify.sh' is not following our default format, this commit returns to old format the newest line brought
…irc_notification
…irc_notification
jackyhuang85
pushed a commit
to jackyhuang85/netdata
that referenced
this pull request
Jan 1, 2020
* fix_irc_notification: Remove line break from message The line break present on netdata alarms are creating 421 errors on the server, this is happening because according RFC1459 this is the end of the message * fix_irc_notification: Adjust tabulatin the script 'alarm-notify.sh' is not following our default format, this commit returns to old format the newest line brought
Saruspete
pushed a commit
to Saruspete/netdata
that referenced
this pull request
May 21, 2020
* fix_irc_notification: Remove line break from message The line break present on netdata alarms are creating 421 errors on the server, this is happening because according RFC1459 this is the end of the message * fix_irc_notification: Adjust tabulatin the script 'alarm-notify.sh' is not following our default format, this commit returns to old format the newest line brought
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7233
When Netdata is sending messages to IRC channels, the messages are generating the error 421, because our default message is not according RFC1459(https://tools.ietf.org/html/rfc1459#section-2.3.1 ), this PR replaces the line break with commas to fix the problem.
Component Name
Alarms
Additional Information
I used the server ircd-hybrid to develop, because I wanted to have messages from both sides, but it is possible to do a simpler test, this PR must avoid the error.log to have error messages 421 when we send an alarm.