Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition in dbengine #7533

Merged
merged 1 commit into from Dec 16, 2019
Merged

Fix race condition in dbengine #7533

merged 1 commit into from Dec 16, 2019

Conversation

mfundul
Copy link
Contributor

@mfundul mfundul commented Dec 15, 2019

Summary

Fixes #7440

Component Name

database/engine

Additional Information

Fix race condition in dbengine and add reproduction support in stress test.

@squash-labs
Copy link

squash-labs bot commented Dec 15, 2019

Manage this branch in Squash

Test this branch here: https://mfundulfix-dbengine-race-condi-kef6j.squash.io

thiagoftsm
thiagoftsm previously approved these changes Dec 15, 2019
Copy link
Contributor

@thiagoftsm thiagoftsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After few hours running without raise errors or alarms I believe this is ready to be merged.

amoss
amoss previously approved these changes Dec 16, 2019
Copy link
Contributor

@amoss amoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after discussion with @mfundul about the locking semantics.

@mfundul mfundul dismissed stale reviews from amoss and thiagoftsm via 02d5934 December 16, 2019 12:26
Copy link
Contributor

@amoss amoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see any changes from the rebase.

@mfundul mfundul merged commit 53ab093 into netdata:master Dec 16, 2019
@mfundul mfundul deleted the fix-dbengine-race-condition branch December 16, 2019 14:14
amoss added a commit that referenced this pull request Dec 17, 2019
We are removing this fix for further internal testing, it will be returning after we iron out
some bugs.

This reverts commit 53ab093.
jackyhuang85 pushed a commit to jackyhuang85/netdata that referenced this pull request Jan 1, 2020
jackyhuang85 pushed a commit to jackyhuang85/netdata that referenced this pull request Jan 1, 2020
We are removing this fix for further internal testing, it will be returning after we iron out
some bugs.

This reverts commit 53ab093.
Saruspete pushed a commit to Saruspete/netdata that referenced this pull request May 21, 2020
Saruspete pushed a commit to Saruspete/netdata that referenced this pull request May 21, 2020
We are removing this fix for further internal testing, it will be returning after we iron out
some bugs.

This reverts commit 53ab093.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Netdata stops working after some time: lots of sockets in CLOSE_WAIT from prometheus remote host
4 participants