New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix race condition in dbengine #7533
Conversation
Manage this branch in SquashTest this branch here: https://mfundulfix-dbengine-race-condi-kef6j.squash.io |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After few hours running without raise errors or alarms I believe this is ready to be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved after discussion with @mfundul about the locking semantics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't see any changes from the rebase.
We are removing this fix for further internal testing, it will be returning after we iron out some bugs. This reverts commit 53ab093.
We are removing this fix for further internal testing, it will be returning after we iron out some bugs. This reverts commit 53ab093.
Summary
Fixes #7440
Component Name
database/engine
Additional Information
Fix race condition in dbengine and add reproduction support in stress test.