Fix erroneous \n printed in uninstaller #8446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prologic
requested review from
cosmix,
Ferroin,
knatsakis and
ncmans
as code owners
Manage this branch in SquashTest this branch here: https://prologicfix-newlines-uninstall-skm1p.squash.io |
github-actions
bot
added
the
area/packaging
thiagoftsm
reviewed
Mar 20, 2020
knatsakis
previously approved these changes
Mar 20, 2020
|
@prologic, please, take a look in |
Ferroin
previously approved these changes
Mar 20, 2020
thiagoftsm
previously approved these changes
Mar 20, 2020
prologic
dismissed stale reviews from thiagoftsm, Ferroin, and knatsakis
via
dc46212
Done Thank you! $ shellcheck packaging/installer/netdata-uninstaller.sh | wc -l
0 |
thiagoftsm
previously approved these changes
Mar 23, 2020
|
@prologic , please, do a rebase here. |
knatsakis
approved these changes
Mar 25, 2020
thiagoftsm
approved these changes
Mar 25, 2020
Saruspete
pushed a commit
to Saruspete/netdata
that referenced
this pull request
May 21, 2020
* Fix erroneous \n printed in uninstaller * Fixed shellcheck errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As per title.
See #8422
Component Name
Test Plan
Beofre:
Deleting netdata user from docker group ... [/root]# gpasswd -d netdata docker \nRemoving user netdata from group docker OK gpasswd -d netdata dockerAfter:
Deleting netdata user from docker group ... [/root]# gpasswd -d netdata docker Removing user netdata from group docker OKAdditional Information
When you do
printf "%s" "${foo}"don't doprintf "%s" "${foo}\n"itdoesn't do what you expect, it treats the
\nas escapced raw text in thesubsitution.