packaging: fix errors during install-requred-packages

[ilyam8]

Summary

My system:

[ilyam@ilyam-pc ~]$ cat /etc/os-release
NAME="Manjaro Linux"
ID=manjaro
ID_LIKE=arch
PRETTY_NAME="Manjaro Linux"
ANSI_COLOR="1;32"
HOME_URL="https://www.manjaro.org/"
SUPPORT_URL="https://www.manjaro.org/"
BUG_REPORT_URL="https://bugs.manjaro.org/"
LOGO=manjarolinux

There are two errors during execution of install-requred-packages.sh.

• Unknown distribution ID: manjaro
• validate_tree_arch: command not found

First one is minor and is likely expected but it makes me thingking that something is going wrong.

This PR fixed both errors.

Component Name

packaging

Test Plan

I did no tests, i think ci should be enough.

Additional Information

[squash-labs]

Manage this branch in Squash

Test this branch here: https://ilyam8add-manjaro-install-requ-ibxwp.squash.io

[ilyam8]

Probably it is expected

netdata/packaging/installer/install-required-packages.sh

Lines 70 to 72 in a851701

	Supported distributions (DD):
	- arch (all Arch Linux derivatives)

Feel free to wontfix && close the PR @Ferroin @prologic

I did it because i saw Unknow distribution ID message.

[ilyam8]

I see we have only validate_tree_centos

netdata/packaging/installer/install-required-packages.sh

Lines 1318 to 1319 in a851701

	validate_tree_centos() {
	local opts=

It is not clear why we have

netdata/packaging/installer/install-required-packages.sh

Lines 1049 to 1051 in a851701

	validate_package_trees() {
	validate_tree_${tree}
	}

and use it

[prologic]

I did no tests, i think ci should be enough.

Ci is only enough if you actually modify the appropriate workflow and add Manjaro to it :)

[prologic]

@ilyam8 validate_trees() is in case there are other special systems we have to cater for and do "extra" things to modify or alter their package trees. So far this is only CentOS; but "future proof" :)

[ilyam8]

Ci is only enough if you actually modify the appropriate workflow and add Manjaro to it :)

I am not sure this was needed, but take a look

we set distribution in autodetect_distribution. There is no manjaro

netdata/packaging/installer/install-required-packages.sh

Lines 1850 to 1854 in a851701

	if [ -z "${package_installer}" ] || [ -z "${tree}" ]; then
	if [ -z "${distribution}" ]; then
	# we dont know the distribution
	autodetect_distribution || user_picks_distribution
	fi

Then we execute detect_package_manager_from_distribution

netdata/packaging/installer/install-required-packages.sh

Lines 1856 to 1859 in a851701

	# When no package installer is detected, try again from distro info if any
	if [ -z "${package_installer}" ]; then
	detect_package_manager_from_distribution "${distribution}"
	fi

And there we expect manjaro

netdata/packaging/installer/install-required-packages.sh

Lines 341 to 344 in a851701

	detect_package_manager_from_distribution() {
	case "${1,,}" in
	arch* | manjaro*)
	package_installer="install_pacman"

[prologic]

Fine if you don't want/need it tested regularly in CI that's okay :)

I assume this is the correct upstream Docker image to use if we change our minds later?

[ilyam8]

Ci is only enough if you actually modify the appropriate workflow and add Manjaro to it :)

manjaro is arch actually. Main difference is delayed updates (1-2 weeks).

I was fixing cosmetic error to be honest 😄

[ilyam8]

I assume this is the correct upstream Docker image

i guess yes, that jonathonf guy is from the manjaro team

edit: Updated 9 months ago 🤔

[ilyam8]

i am still not sure in e1cec5a

if you @prologic or @Ferroin think we dont need it i remove it

[prologic]

Its fine. Get another approval from @Ferroin and merge it :)

[Ferroin]

This does need to be verified. Current approach does not work, as 'manjaro' isn't a recognized distribution name to match on later for selecting the package manager.

[ilyam8]

Current approach does not work, as 'manjaro' isn't a recognized distribution name to match on later for selecting the package manager.

netdata/packaging/installer/install-required-packages.sh

Lines 341 to 344 in a851701

	detect_package_manager_from_distribution() {
	case "${1,,}" in
	arch* | manjaro*)
	package_installer="install_pacman"

[Ferroin]

Current approach does not work, as 'manjaro' isn't a recognized distribution name to match on later for selecting the package manager.

netdata/packaging/installer/install-required-packages.sh

Lines 341 to 344 in a851701

	detect_package_manager_from_distribution() {
	case "${1,,}" in
	arch* | manjaro*)
	package_installer="install_pacman"

Sorry, missed that somehow.

[ilyam8]

as 'manjaro' isn't a recognized distribution name to match on later for selecting the package manager.

if it was the case, ci would fail, right? i am asking because i did no tests, i rely on ci checks

[Ferroin]

as 'manjaro' isn't a recognized distribution name to match on later for selecting the package manager.

if it was the case, ci would fail, right? i am asking because i did no tests, i rely on ci checks

Manjaro isn't in our CI checks at all. There appear to be no up-to-date Docker images for it at the moment AFAICT. Long term we should probably tr and get it added, but It's mostly just old Arch with a fancy installer and some slightly different default behavior, so it's not exactly high priority.

[ilyam8]

Manjaro isn't in our CI checks at all.

i mean install-required-packages job would fail if we had no manjaro here?

🙈 ok, i understood