Fixed bundling of dashboard in binary packages. #8844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes somd code from the dashboard bundling script that was left over from before we changed how we were handling prefixing the old dashboard. The script did not get properl tested after that change in design, so the code unfortunately made it into master and broke package builds.
Ferroin
requested review from
cosmix,
knatsakis,
ncmans and
prologic
as code owners
Manage this branch in SquashTest this branch here: https://ferroinfix-package-builds-6ides.squash.io |
github-actions
bot
added
the
area/packaging
prologic
approved these changes
Apr 28, 2020
knatsakis
approved these changes
Apr 28, 2020
Saruspete
pushed a commit
to Saruspete/netdata
that referenced
this pull request
May 21, 2020
This removes some code from the dashboard bundling script that was left over from before we changed how we were handling prefixing the old dashboard. The script did not get properly tested after that change in design, so the code unfortunately made it into master and broke package builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This removes some code from the dashboard bundling script that was left over from before we changed how we were handling prefixing the old dashboard. The script did not get properly tested after that change in design, so the code unfortunately made it into master and broke package builds.
Component Name
area/packaging
Test Plan
Verified locally for both DEB and RPM packages.