Fixed bug in accepting empty lines in parser #9158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manage this branch in SquashTest this branch here: https://stelfragfix-accept-empty-lines-6q697.squash.io |
mfundul
approved these changes
May 26, 2020
|
After the change charts.d, go.d, python.d work ilyam@debian-s-1vcpu-1gb-fra1-01:~/src/netdata$ ps faxu | grep [n]etdata
ilyam 3496 0.0 0.0 12716 932 pts/0 S+ 07:42 0:00 \_ grep netdata
netdata 3066 1.5 7.9 244820 80788 ? Ssl 07:41 0:00 /opt/netdata/usr/sbin/netdata -P /opt/netdata/var/run/netdata/netdata.pid -D
netdata 3083 0.0 0.2 44320 2328 ? Sl 07:41 0:00 \_ /opt/netdata/usr/sbin/netdata --special-spawn-server
netdata 3221 0.9 0.4 35304 4684 ? S 07:41 0:00 \_ /opt/netdata/usr/libexec/netdata/plugins.d/apps.plugin 1 no-groups no-users
netdata 3223 0.2 0.3 10224 3288 ? S 07:41 0:00 \_ bash /opt/netdata/usr/libexec/netdata/plugins.d/charts.d.plugin 1
netdata 3224 1.9 5.1 107020 52952 ? Sl 07:41 0:01 \_ /usr/bin/python /opt/netdata/usr/libexec/netdata/plugins.d/python.d.plugin 1
netdata 3225 0.3 1.8 125180 18712 ? Sl 07:41 0:00 \_ /opt/netdata/usr/libexec/netdata/plugins.d/go.d.plugin 1 |
ilyam8
approved these changes
May 26, 2020
amoss
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9156
Summary
Empty lines should be ignored and not trigger an error
Component Name
Test Plan
Additional Information