Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration between eBPF and Apps #9178

Merged
merged 94 commits into from Jun 12, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
94 commits
Select commit Hold shift + click to select a range
9186079
ebpf_apps: Create files to do integration
thiagoftsm May 26, 2020
1c25f5f
ebpf_apps: move functions from apps to ebpf part 1
thiagoftsm May 26, 2020
0bf9b75
ebpf_apps: move functions from apps to ebpf part 2
thiagoftsm May 26, 2020
c8d4295
ebpf_apps: Functions to read apps_groups.conf
thiagoftsm May 26, 2020
ef4ee9c
ebpf_apps: reset structures
thiagoftsm May 26, 2020
af8ad8c
ebpf_apps: Verify user running plugin
thiagoftsm May 27, 2020
6449616
ebpf_apps: Adjust structures used for eBPF.plugin
thiagoftsm May 27, 2020
7073fab
rebase
thiagoftsm May 28, 2020
df2dd4a
ebpf_apps: Move ebpf submenu near apps submenu
thiagoftsm May 28, 2020
4ca28b9
ebpf_apps: Brings structures from kernel-collector repository4
thiagoftsm May 28, 2020
5ba0342
ebpf_apps: Set definitions for the new chart names
thiagoftsm May 29, 2020
cb7761f
ebpf_apps: bring new functions to read data from kernel ring
thiagoftsm May 29, 2020
416c350
ebpf_apps: New variable to store PID information on process thread
thiagoftsm May 29, 2020
4028a94
ebpf_apps: It brings PID variable to socket
thiagoftsm May 29, 2020
7bb6d53
ebpf_apps: Chart creation
thiagoftsm May 31, 2020
cb62880
ebpf_apps: New probe
thiagoftsm Jun 1, 2020
2b50e2f
ebpf_apps: Fix order
thiagoftsm Jun 1, 2020
f123d9d
ebpf_apps: Clean targets
thiagoftsm Jun 1, 2020
7d964a2
ebpf_apps: Necessary changes to avoid parse proc
thiagoftsm Jun 2, 2020
390ac96
rebase
thiagoftsm Jun 2, 2020
cb4c6a2
ebpf_apps: Fix key inside collect_data_for_all_processes to remove in…
thiagoftsm Jun 2, 2020
c3637c9
ebpf_apps: Bring variables to read data from hash table
thiagoftsm Jun 2, 2020
8ebfe04
ebpf_apps: Fix coverity warnings
thiagoftsm Jun 2, 2020
ad63111
ebpf_apps: Fix the missing allocation for all_pids and another small …
thiagoftsm Jun 3, 2020
9dffa50
ebpf_apps: Postpone thread creation to fill targets
thiagoftsm Jun 3, 2020
d8af31c
ebpf_apps: Add comments while functions were tested
thiagoftsm Jun 3, 2020
6505d8c
ebpf_apps: Fix LGTM warnings
thiagoftsm Jun 3, 2020
c68f36c
ebpf_apps: Clean allocated structure with raw data
thiagoftsm Jun 3, 2020
b17c2e4
ebpf_apps: Bring missing functions to calculate apps charts for process
thiagoftsm Jun 3, 2020
3ca21bf
ebpf_apps: Rename a function and update apps_groups.conf
thiagoftsm Jun 3, 2020
4273081
ebpf_apps: Copy logic for chart creation to sockets
thiagoftsm Jun 3, 2020
21f9c1f
ebpf_apps: Remove unecessary variable
thiagoftsm Jun 3, 2020
e101928
Update chart creating
vlvkobal Jun 3, 2020
9017746
Remove Users and User Groups targets
vlvkobal Jun 3, 2020
edd47bf
ebpf_apps: missing argument
thiagoftsm Jun 3, 2020
ff878b0
ebpf_apps: Fix LGTM https://github.com/netdata/netdata/pull/9178#issu…
thiagoftsm Jun 3, 2020
39fd741
eb^C_apps: Remove error messages adding read of proc file
thiagoftsm Jun 3, 2020
74effaa
Synchronize getting and sending data
vlvkobal Jun 3, 2020
85180d1
ebpf_apps: Missing function
thiagoftsm Jun 4, 2020
9f06ec7
ebpf_apps: Move socket chart creation and change necessary functions
thiagoftsm Jun 4, 2020
e75b519
ebpf_apps: Bring missing loop to reset variable
thiagoftsm Jun 4, 2020
a800eeb
ebpf_apps: Remove unecessary sleep
thiagoftsm Jun 4, 2020
864c8b7
ebpf_apps: Fix return and allocation to allow the
thiagoftsm Jun 4, 2020
6952cab
ebpf_apps: create structure to set apps dimension
thiagoftsm Jun 4, 2020
8cfe9ad
ebpf_apps: create structure to set apps dimension for socket
thiagoftsm Jun 4, 2020
5974e98
ebpf_apps: Fix wrong family for process
thiagoftsm Jun 4, 2020
de468ff
ebpf_apps: Enable apps by default
thiagoftsm Jun 4, 2020
6cfd170
Functions to enable charts for apps
thiagoftsm Jun 4, 2020
1886533
Fix small bugs
thiagoftsm Jun 4, 2020
3a3609f
ebpf_apps: Fix missing root_pid
thiagoftsm Jun 5, 2020
819b975
Fix negative output on charts
thiagoftsm Jun 5, 2020
b8db1d6
ebpf_apps: Remove debug messages from process
thiagoftsm Jun 5, 2020
075bd3c
ebpf_apps: Fix socket lock scheme
thiagoftsm Jun 5, 2020
92af609
ebpf_apps: Small fixes
thiagoftsm Jun 5, 2020
0108b22
ebpf_apps; Remove unecessary function call and header
thiagoftsm Jun 5, 2020
7d8658b
ebpf_apps: Enable apps by default
thiagoftsm Jun 5, 2020
0454bbc
remove wrong files
thiagoftsm Jun 5, 2020
30a2ba9
ebpf_apps: update cheksum
thiagoftsm Jun 5, 2020
451eb45
Update dashboard.info bringing missing parameters for charts that do …
thiagoftsm Jun 5, 2020
c64fbf0
Fix a bug
vlvkobal Jun 5, 2020
fc626bb
ebpf_apps: Fix open of proc files that are not more present
thiagoftsm Jun 5, 2020
76b3c1d
ebpf_apps:Fix synchronization problems
thiagoftsm Jun 6, 2020
0126fc3
ebpf_apps: Remove dupplication that was killing socket charts
thiagoftsm Jun 6, 2020
010c389
ebpf_apps: Fix codacy warnings
thiagoftsm Jun 6, 2020
99568be
ebpf_apps: Fix process read from memory
thiagoftsm Jun 6, 2020
af0ee42
ebpf_apps: Remove unecessary variable from code
thiagoftsm Jun 7, 2020
dec2206
ebpf_apps: Fix wrong variable usage
thiagoftsm Jun 7, 2020
8a85724
ebpf_apps: complete separation between global and apps charts
thiagoftsm Jun 7, 2020
8e06fc9
Fix missing check and a wrong check
thiagoftsm Jun 8, 2020
2b707f9
ebpf_apps: Comment unnecessary code copied from apps_plugin.c
thiagoftsm Jun 8, 2020
9480d98
ebpf_apps: Restart ebpf when number of monitored PIDs is smaller than…
thiagoftsm Jun 9, 2020
ff8b79e
ebpf_apps: Fix coverity scan error
thiagoftsm Jun 9, 2020
db7fc52
ebpf_release: Update release version
thiagoftsm Jun 9, 2020
a81a246
ebpf_apps: Remove unecessary test
thiagoftsm Jun 9, 2020
c16e632
ebpf_apps: Remove unecessary error message
thiagoftsm Jun 9, 2020
167a806
ebpf_apps: Clean probes during the startup
thiagoftsm Jun 9, 2020
74f6720
ebpf_apps: Bring additional variables to monitor chart plot
thiagoftsm Jun 9, 2020
2ec17a6
ebpf_apps: Missing chart when entry mode is enabled
thiagoftsm Jun 9, 2020
1d625c0
ebpf_apps: Do synchronization between apps.plugin and ebpf.plugin dim…
thiagoftsm Jun 10, 2020
21ba282
ebpf_apps: socket synchronization
thiagoftsm Jun 10, 2020
910a3a2
ebpf_apps: fix problems with task_close
thiagoftsm Jun 10, 2020
f5d92ec
ebpf_apps: Brings title to charts
thiagoftsm Jun 11, 2020
54bbada
ebpf_apps: restore to fix errors
thiagoftsm Jun 11, 2020
d8b3458
ebpf_apps: Remove hard code update every
thiagoftsm Jun 11, 2020
c680ab3
ebpf_apps: rename variables
thiagoftsm Jun 11, 2020
7a6370c
ebpf_apps: Bring title for the charts
thiagoftsm Jun 11, 2020
ef97c5f
ebpf_apps: Remove unecessary line
thiagoftsm Jun 11, 2020
6d81982
ebpf_apps: bring new release to PR
thiagoftsm Jun 11, 2020
5cd830f
ebpf_apps: Fix constant value when a function is not used for a process
thiagoftsm Jun 11, 2020
724a803
ebpf_apps: This fixes a possible memory leak
thiagoftsm Jun 11, 2020
5b21a70
ebpf_apps: move delete function to bring back synchronization between…
thiagoftsm Jun 11, 2020
c82dd4a
Change chart type
thiagoftsm Jun 11, 2020
31d3caa
Fix for exited pids
vlvkobal Jun 12, 2020
952e272
Merge pull request #5 from vlvkobal/fix-for-exited-pids
thiagoftsm Jun 12, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions CMakeLists.txt
Expand Up @@ -431,6 +431,8 @@ set(EBPF_PROCESS_PLUGIN_FILES
collectors/ebpf.plugin/ebpf_process.h
collectors/ebpf.plugin/ebpf_socket.c
collectors/ebpf.plugin/ebpf_socket.h
collectors/ebpf.plugin/ebpf_apps.c
collectors/ebpf.plugin/ebpf_apps.h
)

set(PROC_PLUGIN_FILES
Expand Down
2 changes: 2 additions & 0 deletions Makefile.am
Expand Up @@ -273,6 +273,8 @@ EBPF_PLUGIN_FILES = \
collectors/ebpf.plugin/ebpf_socket.c \
collectors/ebpf.plugin/ebpf_socket.h \
collectors/ebpf.plugin/ebpf.h \
collectors/ebpf.plugin/ebpf_apps.c \
collectors/ebpf.plugin/ebpf_apps.h \
$(LIBNETDATA_FILES) \
$(NULL)

Expand Down
1 change: 1 addition & 0 deletions collectors/apps.plugin/apps_groups.conf
Expand Up @@ -86,6 +86,7 @@ fping: fping
ioping: ioping
go.d.plugin: *go.d.plugin*
slabinfo.plugin: slabinfo.plugin
ebpf.plugin: *ebpf.plugin*

# -----------------------------------------------------------------------------
# authentication/authorization related servers
Expand Down
3 changes: 2 additions & 1 deletion collectors/apps.plugin/apps_plugin.c
Expand Up @@ -2451,7 +2451,8 @@ static inline void link_all_processes_to_their_parents(void) {
p->parent = NULL;

if(unlikely(!p->ppid)) {
p->parent = NULL;
//unnecessary code from apps_plugin.c
//p->parent = NULL;
continue;
}

Expand Down