Fix PyMySQL library to respect my.cnf parameter
#9526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manage this branch in SquashTest this branch here: https://anirudhdgglissue-7518-y6t6n.squash.io |
|
|
github-actions
bot
added
area/collectors
ilyam8
reviewed
Jul 11, 2020
collectors/python.d.plugin/python_modules/bases/FrameworkServices/MySQLService.py
Show resolved
Hide resolved
|
@anirudhdggl we need you to sign the CLA to get this PR merged |
ilyam8
approved these changes
Jul 11, 2020
|
SIgned. |
I guess this is not hard requirement. Indeed old versions of pymysql didnt support loading from @anirudhdggl thx for contribution! |
|
i see pymysql has |
ilyam8
changed the title
my.cnf parameter using PyMySQL library
joelhans
changed the title
my.cnf parameter using PyMySQL librarymy.cnf parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7518
Component Name
MySQLService.py
Test Plan
Have original users who raised the issue verify it
Additional Information
As mentioned in one of the issue comment, the requisite code block responsible for the issue has been removed so that no one faces this issue again