Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading custom dashboard_info in /old dashboard #9792

Merged

Conversation

jacekkolasa
Copy link
Contributor

Summary

fixes #9787
Old dashboard accessed with /old suffix was not loading custom dashboard_info.js files.

Component Name

web

Test Plan

In /etc/netdata.conf

[web]
   custom dashboard_info.js = dashboard_info_custom.js

dashboard should not show error, and the dashboard_info_custom.js file should be loaded by browser.

Copy link
Contributor

@thiagoftsm thiagoftsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied my dashboard_info.js to dashboard_info_custom.js as suggested and I had 200 result using react dashboard and /old. LGTM!

@thiagoftsm
Copy link
Contributor

@jacekkolasa and @joelhans , I observed that when I ran the next command:

bash-5.0$ grep -r "custom dashboard_info.js" *

I only had the option inside our source code, but we do not have any information inside our documentation file, please, can you made another PR given more details about the option custom dashboard_info.js? Thank you!

@jacekkolasa
Copy link
Contributor Author

@thiagoftsm thanks for checking!
Actually we have documentation for this feature, here - https://learn.netdata.cloud/docs/agent/web/gui#customizing-the-standard-dashboard

@jacekkolasa jacekkolasa merged commit b62a02e into netdata:master Aug 22, 2020
@jacekkolasa jacekkolasa deleted the old-dashboard-custom-info-js-fix branch August 22, 2020 21:01
@thiagoftsm
Copy link
Contributor

@thiagoftsm thanks for checking!
Actually we have documentation for this feature, here - https://learn.netdata.cloud/docs/agent/web/gui#customizing-the-standard-dashboard

Thank you, I missed this reference when I ran a grep! :)

@joelhans joelhans changed the title fix loading custom dashboard_info in /old dashboard Fix loading custom dashboard_info in /old dashboard Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dashboard_info.js Error 400
4 participants