Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interfaces are updated event though it's not needed #94

Closed
MrBE4R opened this issue Mar 17, 2023 · 2 comments · Fixed by #95
Closed

Interfaces are updated event though it's not needed #94

MrBE4R opened this issue Mar 17, 2023 · 2 comments · Fixed by #95
Assignees
@emersonfelipesp
Labels
accepted This issue has been accepted for implementation

Comments

@MrBE4R
Copy link
Contributor

MrBE4R commented Mar 17, 2023 •
edited
Loading

Hi,

Due to some inconsistencies between the following lines :
https://github.com/netdevopsbr/netbox-proxbox/blob/v0.0.5/netbox_proxbox/proxbox_api/updates/virtual_machine.py#L310
https://github.com/netdevopsbr/netbox-proxbox/blob/v0.0.5/netbox_proxbox/proxbox_api/updates/virtual_machine.py#L327

The plugin detect that it should update the interfaces.

We should either force .lower() or .upper() on both to avoid false positive.

Cheers.
@emersonfelipesp emersonfelipesp self-assigned this Mar 17, 2023
@emersonfelipesp emersonfelipesp added the accepted This issue has been accepted for implementation label Mar 17, 2023
@emersonfelipesp emersonfelipesp linked a pull request Mar 20, 2023 that will close this issue
Close #94 - Fix duplicate update due to case sensitive mismatch #95
Merged
@emersonfelipesp
Copy link
Member

Hi @MrBE4R could you please review if it is ok like the way I did?
I kept the regex considering lower case and if it matches, I use .upper() as I think it may be better readable.
Thank you already!

@MrBE4R
Copy link
Contributor Author

MrBE4R commented Mar 20, 2023

Hi @emersonfelipesp that's what I did to correct our instance.

Cheers

emersonfelipesp added a commit that referenced this issue Mar 21, 2023
@emersonfelipesp
Merge pull request #95 from netdevopsbr/fix-interface-update
2b515db 
Close #94 - Fix duplicate update due to case sensitive mismatch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emersonfelipesp emersonfelipesp

Labels
accepted This issue has been accepted for implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Close #94 - Fix duplicate update due to case sensitive mismatch netdevopsbr/netbox-proxbox
2 participants
@MrBE4R @emersonfelipesp