Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added exinda mibs and updated fortinet #55

Closed
wants to merge 3 commits into from
Closed

added exinda mibs and updated fortinet #55

wants to merge 3 commits into from

Conversation

inphobia
Copy link
Member

first try at getting exinda mibs known

@inphobia
Copy link
Member Author

added exinda mibs, updated fortinet (but it seems fortinet merged the analyzer & manager diffs in 1 file)

@inphobia inphobia changed the title added exinda mibs added exinda mibs and updated fortinet Oct 25, 2018
@inphobia
Copy link
Member Author

upon closer inspection, while this is the latest version released by fortinet of fortinet-fortigate-mib.mib, several fortigate models have gone missing.

for example:
fgt60ADSL OBJECT IDENTIFIER ::= { fgModel 602 }

is no longer present in the version. perhaps the product is end of life, but what are the guidelines when items get removed from an official mib?

@JeroenvIS
Copy link
Member

but what are the guidelines when items get removed from an official mib?

I'm not sure whether we have "official" guidelines on that, but my rule of thumb is:

  • Keep as many uniqe translations as possible
  • Try to maintain a MIB set that is better than the official vendor release
  • Don't remove obsolete translations

eg in the HP/ProCurve product range, I also try to keep objects for products that showed up in the MIB at some point, but haven't actually been released. Downside is that it makes MIB maintenance more difficult though.

@inphobia
Copy link
Member Author

i've been thinking about this for a while but it seems a maintenance problem that will be only be getting bigger as time goes on. perhaps the mailinglist is a better place to take this discussion, but i'll alrdy write it down here for further reference.

to me it seems like an interesting idea to have the vendor provided mibs as is in netdisco, to making updating straightforward, but provide some kind patch/diff file with models and/or other items that the vendor has removed but we wish to keep in.

this could:

  • make updating mibs more of copy & replace file process that's the same for all vendors.
  • make it clear what local changes are to the mibs
  • make it clear there are indeed local changes made to the mibs so they are less likely to get missed in further updates.

there is alrdy quite a bit of this infrastructure in place, since the mib update process (https://github.com/netdisco/netdisco-mibs/wiki/Updating-MIBs) compares contents in steps 10 -> 12. perhaps removals can be caught here and kept track for the changes/additions/removals we like to keep compared to the current vendor mibs?

i'll see what i'll do with this pull request, since the fortinet part is clearly botched due to removals. the exinda part ( 51c5a4a ) however seems fine to me & will be needed for for the snmp::info exinda module i'm almost done with.

@inphobia
Copy link
Member Author

finally figuring out how git works, so made a clean branch with just the exinda changes. will close this pull request. fortinet updates are still in the pipeline but need more work.

clean pull request in #60

@inphobia inphobia closed this Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants