#642 requests to /admin/unknown-thing do not get 404

netdisco · Sep 3, 2019 · 82a99ea · 82a99ea
1 parent 2897eda
commit 82a99ea
Showing 1 changed file with 14 additions and 7 deletions.
diff --git a/lib/App/Netdisco/Web/AdminTask.pm b/lib/App/Netdisco/Web/AdminTask.pm
@@ -59,13 +59,20 @@ ajax qr{/ajax/control/admin/(?:\w+/)?delete} => require_role setting('defanged_a
 get '/admin/*' => require_role admin => sub {
     my ($tag) = splat;
 
-    # trick the ajax into working as if this were a tabbed page
-    params->{tab} = $tag;
-
-    var(nav => 'admin');
-    template 'admintask', {
-      task => setting('_admin_tasks')->{ $tag },
-    };
+    if (exists setting('_admin_tasks')->{ $tag }) {
+      # trick the ajax into working as if this were a tabbed page
+      params->{tab} = $tag;
+
+      var(nav => 'admin');
+      template 'admintask', {
+        task => setting('_admin_tasks')->{ $tag },
+      };
+    }
+    else {
+      var('notfound' => true);
+      status 'not_found';
+      template 'index';
+    }
 };
 
 true;