SqPandasEngine.get_table_df() has broken code

[jopietsch]

I don't know how to get the code to execute, but this, starting at line 114 is clearly broken, it tries to use files before it is assigned and doesn't have a colon after files.

                jobs = [
                    exe.submit(self.read_pq_file, f, fields, query_str)
                    for f in files
                ]

it's in a section that starts out with if use_get_files, so we must never be using use_get_files. I don't know what that does or how to test it.

[ddutt]

:)
Thats valid python. Its not broken. files is assigned on line 74.

[jopietsch]

yeah, that part is valid, sorry.
but the 'for f in files' without a colon isn't, is it?

[jopietsch]

nevermind :(