Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How does dyno know about redis is unavailable? #176

Closed
lampmanyao opened this issue Jun 22, 2017 · 1 comment
Closed

How does dyno know about redis is unavailable? #176

lampmanyao opened this issue Jun 22, 2017 · 1 comment

Comments

@lampmanyao
Copy link

lampmanyao commented Jun 22, 2017

Hi, here is my test case, and i use hiredis client:
0) dyno client reads a key

  1. dynomite replies "ERR Storage: Connection refused" if it's redis was unavailable

Because hiredis can read something from dynomite, so redisContext's err field would not be set to ERROR, and the redisReply is not NULL. We get the wrong value.

My question is:
How does dyno handle this situation?

@lampmanyao
Copy link
Author

We won't get the wrong value.
Because redisReply has a type field, in this situation, it will be set to REDIS_REPLY_ERROR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant