-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No "com.netflix.servo" prefix for tag? #202
Comments
It looks like the domain for the jmx ObjectName is configurable when using the JmxMonitorRegistry directly, but not when used via the DefaultMonitorRegistry which is how most access it. It should be relatively straightforward to add a property to change that. Regarding the other issue, I think that is a duplicate of the broader discussion in: #155 We need to offer more flexibility with how the data gets mapped to jmx, which is planned, just have to find time to actually do it. |
The best practice so far might be set up VisualVM's "ordered key property list" to have "type,class,name"(or "class,type,name" as someone described in #155 for NetBeans. That way, I was able to pop up JMX tree as I wanted, although either changes doesn't really matter if I don't use visual tools and just polling JMX values and send it to other system for alerting or something. |
Can be changed with a property now. |
Hello, I know this library has invented to be used in Netflix, so it's somewhat makes sense that every JMX monitoring types have "com.netflix.servo" prefix, but maybe it's also make sense to remove those prefix for general use of this library.
Also, some folks may want to show every COUNTER, METER, TIMER types to be located under same position, others may not want those. This is just one line change during instance creation by not adding additional tag.
The text was updated successfully, but these errors were encountered: