Release v5.9.5 fix bug where PATCH operations silently fail #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariuszSki
reviewed
May 3, 2022
dariuszSki
approved these changes
May 3, 2022
dariuszSki
approved these changes
May 3, 2022
…'s in the process of creating an execution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PATCH operations would silently fail because the method compares current / desired state to determine which properties require patching. If the current state has a property like
attributes: []then the faulty logic would "prune" the key which value evaluates to False and therefore never patch propertyattributeswith the desired value.Another bug caused the first server-side page of network-groups to be fetched twice because of a faulty workaround for the API bug where network-groups server-side pages are 1-based instead of 0-based.