New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default installation typos #1

Merged
merged 2 commits into from Apr 6, 2015

Conversation

Projects
None yet
2 participants
@brookinsconsulting
Copy link
Contributor

brookinsconsulting commented Apr 4, 2015

Hello Netgen!

We wanted to take a moment to first thank you for your wonderful work with this dual kernel solution!

During the course of a normal share forum thread, BC found several small but serious problems when trying to use and guide a new ezpublish user through the process of leveraging your solution to solve their use case requirements. http://share.ez.no/forums/ez-publish-5-platform/select-class-attribute-option-values-ez-5.4

The first problem found was a template block name typo which made the default installation usage fail by default.

The second issue was a less serious but while building this pull request using a clean new installation we found that we tried to copy and paste a path for the bundle activation path in the installation instructions. We found the directory separator was reversed which meant we could not copy and paste this path to the ezpublish/EzPublishKernel.php file to activate the bundle on unix based systems.

This pull request solves both those issues. We hope that you agree and will merge our improvements!

Please let us know how this finds you.

Take it eZ!

Cheers,
Brookins Consulting

@brookinsconsulting

This comment has been minimized.

Copy link
Contributor Author

brookinsconsulting commented Apr 6, 2015

Ping @emodric

@emodric

This comment has been minimized.

Copy link
Member

emodric commented Apr 6, 2015

Nice catches! Thanks @brookinsconsulting

emodric added a commit that referenced this pull request Apr 6, 2015

@emodric emodric merged commit 49abaea into netgen:master Apr 6, 2015

@brookinsconsulting

This comment has been minimized.

Copy link
Contributor Author

brookinsconsulting commented Apr 6, 2015

Hello @emodric

Thank you for reviewing and merging our improvements!
It really means a lot to us and everyone in the community!

Cheers,
Brookins Consulting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment