Default installation typos #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…can copy and paste filename path in unix based operating systems
|
Ping @emodric |
|
Nice catches! Thanks @brookinsconsulting |
|
Hello @emodric Thank you for reviewing and merging our improvements! Cheers, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Netgen!
We wanted to take a moment to first thank you for your wonderful work with this dual kernel solution!
During the course of a normal share forum thread, BC found several small but serious problems when trying to use and guide a new ezpublish user through the process of leveraging your solution to solve their use case requirements. http://share.ez.no/forums/ez-publish-5-platform/select-class-attribute-option-values-ez-5.4
The first problem found was a template block name typo which made the default installation usage fail by default.
The second issue was a less serious but while building this pull request using a clean new installation we found that we tried to copy and paste a path for the bundle activation path in the installation instructions. We found the directory separator was reversed which meant we could not copy and paste this path to the
ezpublish/EzPublishKernel.phpfile to activate the bundle on unix based systems.This pull request solves both those issues. We hope that you agree and will merge our improvements!
Please let us know how this finds you.
Take it eZ!
Cheers,
Brookins Consulting