Apply CS to tests

netgen · Sep 16, 2020 · c8738f4 · c8738f4
1 parent 5cca6f0
commit c8738f4
Show file tree

Hide file tree

Showing 19 changed files with 6 additions and 143 deletions.
diff --git a/tests/bundle/DependencyInjection/Configuration/Parser/ContentViewTest.php b/tests/bundle/DependencyInjection/Configuration/Parser/ContentViewTest.php
@@ -124,8 +124,6 @@ public function providerForTestValid(): array
 
     /**
      * @dataProvider providerForTestValid
-     *
-     * @param array $configurationValues
      */
     public function testValid(array $configurationValues): void
     {
@@ -250,9 +248,6 @@ public function providerForTextExtends(): array
     /**
      * @group xxx
      * @dataProvider providerForTextExtends
-     *
-     * @param array $configurationValues
-     * @param array $expectedValues
      */
     public function testExtends(array $configurationValues, array $expectedValues): void
     {
@@ -423,10 +418,6 @@ public function providerForTestInvalid(): array
 
     /**
      * @dataProvider providerForTestInvalid
-     *
-     * @param array $configurationValues
-     * @param string $exceptionClass
-     * @param string $exceptionMessage
      */
     public function testInvalid(array $configurationValues, string $exceptionClass, string $exceptionMessage): void
     {
@@ -563,9 +554,6 @@ public function providerForTestDefaultValues(): array
 
     /**
      * @dataProvider providerForTestDefaultValues
-     *
-     * @param array $configurationValues
-     * @param array $expectedConfigurationValues
      */
     public function testDefaultValues(array $configurationValues, array $expectedConfigurationValues): void
     {

diff --git a/tests/bundle/DependencyInjection/Configuration/Parser/SiteApiTest.php b/tests/bundle/DependencyInjection/Configuration/Parser/SiteApiTest.php
@@ -1,11 +1,11 @@
 <?php
 
+declare(strict_types=1);
 
 namespace Netgen\Bundle\EzPlatformSiteApiBundle\Tests\DependencyInjection\Configuration\Parser;
 
 use eZ\Bundle\EzPublishCoreBundle\DependencyInjection\EzPublishCoreExtension;
 use eZ\Bundle\EzPublishCoreBundle\Tests\DependencyInjection\Configuration\Parser\AbstractParserTestCase;
-use Netgen\Bundle\EzPlatformSiteApiBundle\DependencyInjection\Configuration\Parser\BaseOptions;
 use Netgen\Bundle\EzPlatformSiteApiBundle\DependencyInjection\Configuration\Parser\SiteApi;
 use Symfony\Component\Config\Definition\Exception\InvalidConfigurationException;
 use Symfony\Component\Config\Definition\Exception\InvalidTypeException;
@@ -17,7 +17,7 @@
  *
  * @internal
  */
-class SiteApiTest extends AbstractParserTestCase
+final class SiteApiTest extends AbstractParserTestCase
 {
     public function getBooleanConfigurationNames(): array
     {
@@ -64,10 +64,6 @@ public function providerForTestBooleanConfigurationValid(): \Generator
 
     /**
      * @dataProvider providerForTestBooleanConfigurationValid
-     *
-     * @param string $name
-     * @param mixed $config
-     * @param mixed $expectedValue
      */
     public function testBooleanConfigurationValid(string $name, $config, $expectedValue): void
     {
@@ -116,9 +112,6 @@ public function providerForTestBooleanConfigurationInvalid(): \Generator
 
     /**
      * @dataProvider providerForTestBooleanConfigurationInvalid
-     *
-     * @param string $name
-     * @param mixed $config
      */
     public function testBooleanConfigurationInvalid(string $name, $config): void
     {
@@ -242,10 +235,6 @@ public function providerForTestNamedObjectConfigurationValid(): \Generator
 
     /**
      * @dataProvider providerForTestNamedObjectConfigurationValid
-     *
-     * @param string $name
-     * @param array $configuration
-     * @param mixed $expectedValue
      */
     public function testNamedObjectConfigurationValid(string $name, array $configuration, $expectedValue): void
     {
@@ -318,9 +307,6 @@ public function providerForTestNamedObjectConfigurationInvalid(): \Generator
 
     /**
      * @dataProvider providerForTestNamedObjectConfigurationInvalid
-     *
-     * @param string $name
-     * @param array $configuration
      */
     public function testNamedObjectConfigurationInvalid(string $name, array $configuration): void
     {
@@ -361,9 +347,6 @@ public function providerForTestNamedObjectDefaultValues(): array
 
     /**
      * @dataProvider providerForTestNamedObjectDefaultValues
-     *
-     * @param mixed $configurationValues
-     * @param array $expectedConfigurationValues
      */
     public function testNamedObjectDefaultValues($configurationValues, array $expectedConfigurationValues): void
     {
@@ -427,8 +410,6 @@ public function providerForTestNamedQueryConfigurationValid(): array
 
     /**
      * @dataProvider providerForTestNamedQueryConfigurationValid
-     *
-     * @param array $configurationValues
      */
     public function testNamedQueryConfigurationValid(array $configurationValues): void
     {
@@ -521,9 +502,6 @@ public function providerForTestNamedQueryConfigurationInvalid(): array
 
     /**
      * @dataProvider providerForTestNamedQueryConfigurationInvalid
-     *
-     * @param array $configurationValues
-     * @param string $message
      */
     public function testNamedQueryConfigurationInvalid(array $configurationValues, string $message): void
     {
@@ -566,9 +544,6 @@ public function providerForTestNamedQueryConfigurationDefaultValues(): array
 
     /**
      * @dataProvider providerForTestNamedQueryConfigurationDefaultValues
-     *
-     * @param array $configurationValues
-     * @param array $expectedConfigurationValues
      */
     public function testNamedQueryConfigurationDefaultValues(array $configurationValues, array $expectedConfigurationValues): void
     {

diff --git a/tests/bundle/NamedObject/LoadingProviderTest.php b/tests/bundle/NamedObject/LoadingProviderTest.php
@@ -306,7 +306,7 @@ protected function getTagServiceMock(): MockObject
 
         $mock
             ->method('loadTag')
-            ->willReturnCallback(function ($id) {
+            ->willReturnCallback(static function ($id) {
                 if ($id === 42) {
                     return new Tag(['id' => 42]);
                 }
@@ -316,7 +316,7 @@ protected function getTagServiceMock(): MockObject
 
         $mock
             ->method('loadTagByRemoteId')
-            ->willReturnCallback(function ($id) {
+            ->willReturnCallback(static function ($id) {
                 if ($id === 'abc') {
                     return new Tag(['remoteId' => 'abc']);
                 }

diff --git a/tests/bundle/QueryType/ParameterProcessorTest.php b/tests/bundle/QueryType/ParameterProcessorTest.php
@@ -244,9 +244,6 @@ public function providerForTestProcess(): array
 
     /**
      * @dataProvider providerForTestProcess
-     *
-     * @param mixed $parameter
-     * @param mixed $expectedProcessedParameter
      */
     public function testProcess($parameter, $expectedProcessedParameter): void
     {

diff --git a/tests/bundle/QueryType/QueryDefinitionMapperTest.php b/tests/bundle/QueryType/QueryDefinitionMapperTest.php
@@ -149,9 +149,6 @@ public function providerForTestMap(): array
 
     /**
      * @dataProvider providerForTestMap
-     *
-     * @param array $configuration
-     * @param \Netgen\Bundle\EzPlatformSiteApiBundle\QueryType\QueryDefinition $expectedQueryDefinition
      */
     public function testMap(array $configuration, QueryDefinition $expectedQueryDefinition): void
     {
@@ -252,17 +249,11 @@ protected function getQueryTypeRegistryMock(): MockObject
         return $queryTypeRegistryMock;
     }
 
-    /**
-     * @return \PHPUnit\Framework\MockObject\MockObject
-     */
     protected function getQueryTypeMock(): MockObject
     {
         return $this->getMockBuilder(QueryType::class)->getMock();
     }
 
-    /**
-     * @return \PHPUnit\Framework\MockObject\MockObject
-     */
     protected function getSiteQueryTypeMock(): MockObject
     {
         $queryTypeMock = $this->getMockBuilder(SiteQueryType::class)->getMock();
@@ -276,9 +267,6 @@ protected function getSiteQueryTypeMock(): MockObject
         return $queryTypeMock;
     }
 
-    /**
-     * @return \Netgen\Bundle\EzPlatformSiteApiBundle\QueryType\ParameterProcessor
-     */
     protected function getParameterProcessor(): ParameterProcessor
     {
         /** @var \Symfony\Component\HttpFoundation\RequestStack $requestStack */

diff --git a/tests/bundle/QueryType/QueryExecutorTest.php b/tests/bundle/QueryType/QueryExecutorTest.php
@@ -187,9 +187,6 @@ public function testExecuteLocationPagedFindQuery(): void
         $this->assertTrue($result->getNormalizeOutOfRangePages());
     }
 
-    /**
-     * @return \Netgen\Bundle\EzPlatformSiteApiBundle\QueryType\QueryExecutor
-     */
     protected function getQueryExecutorUnderTest(): QueryExecutor
     {
         return new QueryExecutor(
@@ -280,9 +277,6 @@ protected function getQueryTypeRegistryMock(): MockObject
         return $queryTypeRegistryMock;
     }
 
-    /**
-     * @return \PHPUnit\Framework\MockObject\MockObject
-     */
     protected function getContentQueryTypeMock(): MockObject
     {
         $mock = $this->getMockBuilder(QueryType::class)->getMock();
@@ -293,9 +287,6 @@ protected function getContentQueryTypeMock(): MockObject
         return $mock;
     }
 
-    /**
-     * @return \PHPUnit\Framework\MockObject\MockObject
-     */
     protected function getLocationQueryTypeMock(): MockObject
     {
         $mock = $this->getMockBuilder(QueryType::class)->getMock();

diff --git a/tests/lib/Integration/BaseTest.php b/tests/lib/Integration/BaseTest.php
@@ -77,9 +77,6 @@ public function getData(string $languageCode): array
     }
 
     /**
-     * @param string $name
-     * @param mixed $value
-     *
      * @throws \ReflectionException
      * @throws \ErrorException
      */
@@ -94,8 +91,6 @@ protected function overrideSettings(string $name, $value): void
 
     /**
      * @throws \ErrorException
-     *
-     * @return \Netgen\EzPlatformSiteApi\API\Site
      */
     protected function getSite(): Site
     {

diff --git a/tests/lib/Integration/PrepareFixturesTest.php b/tests/lib/Integration/PrepareFixturesTest.php
@@ -29,8 +29,6 @@ final class PrepareFixturesTest extends APIBaseTest
      * @throws \eZ\Publish\API\Repository\Exceptions\InvalidArgumentException
      * @throws \eZ\Publish\API\Repository\Exceptions\NotFoundException
      * @throws \eZ\Publish\API\Repository\Exceptions\UnauthorizedException
-     *
-     * @return array
      */
     public function testPrepareTestFixtures(): array
     {
@@ -81,22 +79,14 @@ public function testPrepareTestFixtures(): array
     }
 
     /**
-     * @param \eZ\Publish\API\Repository\Values\ContentType\ContentType $contentType
      * @param $parentLocationId
-     * @param string $contentRemoteId
-     * @param string $locationRemoteId
-     * @param string $mainLanguageCode
-     * @param array $languageCodes
-     * @param bool $alwaysAvailable
      *
      * @throws \eZ\Publish\API\Repository\Exceptions\BadStateException
      * @throws \eZ\Publish\API\Repository\Exceptions\ContentFieldValidationException
      * @throws \eZ\Publish\API\Repository\Exceptions\ContentValidationException
      * @throws \eZ\Publish\API\Repository\Exceptions\InvalidArgumentException
      * @throws \eZ\Publish\API\Repository\Exceptions\NotFoundException
      * @throws \eZ\Publish\API\Repository\Exceptions\UnauthorizedException
-     *
-     * @return \eZ\Publish\API\Repository\Values\Content\Content
      */
     protected function createContent(
         ContentType $contentType,
@@ -148,8 +138,6 @@ protected function createContent(
      * @throws \eZ\Publish\API\Repository\Exceptions\InvalidArgumentException
      * @throws \eZ\Publish\API\Repository\Exceptions\NotFoundException
      * @throws \eZ\Publish\API\Repository\Exceptions\UnauthorizedException
-     *
-     * @return \eZ\Publish\API\Repository\Values\ContentType\ContentType
      */
     protected function createContentType(): ContentType
     {

diff --git a/tests/lib/Integration/RelationServiceTest.php b/tests/lib/Integration/RelationServiceTest.php
@@ -175,8 +175,6 @@ public function testLoadFieldRelationsForNonexistentField(): void
      * @throws \eZ\Publish\API\Repository\Exceptions\InvalidArgumentException
      * @throws \eZ\Publish\API\Repository\Exceptions\NotFoundException
      * @throws \eZ\Publish\API\Repository\Exceptions\UnauthorizedException
-     *
-     * @return array
      */
     protected function prepareTestContent(): array
     {

diff --git a/tests/lib/Integration/Traits/SearchResultExtractorStub.php b/tests/lib/Integration/Traits/SearchResultExtractorStub.php
@@ -12,8 +12,6 @@ class SearchResultExtractorStub
     use SearchResultExtractorTrait;
 
     /**
-     * @param \eZ\Publish\API\Repository\Values\Content\Search\SearchResult $searchResult
-     *
      * @return \eZ\Publish\API\Repository\Values\ValueObject[]
      */
     public function doExtractValueObjects(SearchResult $searchResult): array
@@ -22,8 +20,6 @@ public function doExtractValueObjects(SearchResult $searchResult): array
     }
 
     /**
-     * @param \eZ\Publish\API\Repository\Values\Content\Search\SearchResult $searchResult
-     *
      * @return \eZ\Publish\API\Repository\Values\ValueObject[]
      */
     public function doExtractContentItems(SearchResult $searchResult): array
@@ -32,8 +28,6 @@ public function doExtractContentItems(SearchResult $searchResult): array
     }
 
     /**
-     * @param \eZ\Publish\API\Repository\Values\Content\Search\SearchResult $searchResult
-     *
      * @return \eZ\Publish\API\Repository\Values\ValueObject[]
      */
     public function doExtractLocations(SearchResult $searchResult): array

diff --git a/tests/lib/Unit/Core/Site/ContentFieldsMockTrait.php b/tests/lib/Unit/Core/Site/ContentFieldsMockTrait.php
@@ -5,6 +5,7 @@
 namespace Netgen\EzPlatformSiteApi\Tests\Unit\Core\Site;
 
 use eZ\Publish\API\Repository\ContentTypeService;
+use eZ\Publish\API\Repository\FieldType;
 use eZ\Publish\API\Repository\FieldTypeService;
 use eZ\Publish\API\Repository\Values\Content\ContentInfo as RepoContentInfo;
 use eZ\Publish\API\Repository\Values\ContentType\FieldDefinitionCollection;
@@ -13,7 +14,6 @@
 use eZ\Publish\Core\Repository\Values\Content\Content as RepoContent;
 use eZ\Publish\Core\Repository\Values\Content\VersionInfo;
 use eZ\Publish\Core\Repository\Values\ContentType\ContentType;
-use eZ\Publish\API\Repository\FieldType;
 use Netgen\EzPlatformSiteApi\API\Site;
 use Netgen\EzPlatformSiteApi\Core\Site\DomainObjectMapper;
 use PHPUnit\Framework\MockObject\MockBuilder;
@@ -99,11 +99,6 @@ protected function getSiteMock(): MockObject
         return $this->siteMock;
     }
 
-    /**
-     * @param bool $failOnMissingField
-     *
-     * @return \Netgen\EzPlatformSiteApi\Core\Site\DomainObjectMapper
-     */
     protected function getDomainObjectMapper(bool $failOnMissingField = true): DomainObjectMapper
     {
         if (isset($this->domainObjectMapper[$failOnMissingField])) {

diff --git a/tests/lib/Unit/Core/Site/QueryType/Base/CustomQueryTypeTest.php b/tests/lib/Unit/Core/Site/QueryType/Base/CustomQueryTypeTest.php
@@ -143,9 +143,6 @@ public function providerForTestGetQuery(): array
 
     /**
      * @dataProvider providerForTestGetQuery
-     *
-     * @param array $parameters
-     * @param \eZ\Publish\API\Repository\Values\Content\Query $expectedQuery
      */
     public function testGetQuery(array $parameters, Query $expectedQuery): void
     {

diff --git a/tests/lib/Unit/Core/Site/QueryType/Content/Relations/ForwardFieldsTest.php b/tests/lib/Unit/Core/Site/QueryType/Content/Relations/ForwardFieldsTest.php
@@ -15,11 +15,11 @@
 use eZ\Publish\API\Repository\Values\Content\Query\Criterion\Operator;
 use eZ\Publish\API\Repository\Values\Content\Query\SortClause\ContentName;
 use eZ\Publish\API\Repository\Values\Content\Query\SortClause\DatePublished;
-use eZ\Publish\Core\Repository\Values\ContentType\FieldDefinitionCollection;
 use eZ\Publish\Core\FieldType\Relation\Value as RelationValue;
 use eZ\Publish\Core\FieldType\RelationList\Value as RelationListValue;
 use eZ\Publish\Core\FieldType\TextLine\Value;
 use eZ\Publish\Core\Repository\Values\ContentType\FieldDefinition;
+use eZ\Publish\Core\Repository\Values\ContentType\FieldDefinitionCollection;
 use Netgen\EzPlatformSiteApi\Core\Site\Plugins\FieldType\RelationResolver\Registry;
 use Netgen\EzPlatformSiteApi\Core\Site\Plugins\FieldType\RelationResolver\Resolver\Relation;
 use Netgen\EzPlatformSiteApi\Core\Site\Plugins\FieldType\RelationResolver\Resolver\RelationList;

diff --git a/tests/lib/Unit/Core/Site/QueryType/CriteriaBuilderTest.php b/tests/lib/Unit/Core/Site/QueryType/CriteriaBuilderTest.php
@@ -437,9 +437,6 @@ public function testBuildDateMetadataThrowsException(): void
         ]);
     }
 
-    /**
-     * @return \Netgen\EzPlatformSiteApi\Core\Site\QueryType\CriteriaBuilder
-     */
     protected function getCriteriaBuilderUnderTest(): CriteriaBuilder
     {
         if ($this->criteriaBuilder === null) {