Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid type error if array not passed #1

Merged
merged 2 commits into from
Oct 18, 2019
Merged

Avoid type error if array not passed #1

merged 2 commits into from
Oct 18, 2019

Conversation

wizhippo
Copy link
Contributor

php throws error if $value['keywords'] is null

@wizhippo
Avoid type error if array not passed
d051e37 
php throws error if $value['keywords'] is null
emodric
emodric reviewed Oct 18, 2019
View reviewed changes
Copy link
Member

@emodric emodric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Douglas!

We can use $value['keywords'] ?? '' rather than casting, for making the intention more clearer.

@emodric emodric merged commit a545df4 into netgen:master Oct 18, 2019
@emodric
Copy link
Member

emodric commented Oct 18, 2019

Thanks!

@wizhippo wizhippo deleted the patch-1 branch October 18, 2019 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emodric emodric emodric left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wizhippo @emodric