-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NAE-1156] View Deprecation and All Data #86
Conversation
-remove deprecated view tag
src/main/java/com/netgrif/application/engine/importer/service/FieldFactory.java
Outdated
Show resolved
Hide resolved
-fix according to PR
Kudos, SonarCloud Quality Gate passed! |
- add caching config and declare caches - make get methods of PetriNetService cacheable
- add test to check if cache working - add cache resolver to resolve new caches - create cache properties to enable setting names of caches from properties
- fix according to PR
- fix according to Sonar
- simplify cache properties - refactor cache resolver and cache configuration
- fix code smell
- PDF UserList
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Kudos, SonarCloud Quality Gate passed! |
Description
-remove deprecated view tag
Fixes NAE-1156
Dependencies
none
Third party dependencies
none
Blocking Pull requests
none
How Has Been This Tested?
manually
Checklist: