Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Names of resources created by the operator #139

Closed
fraborg opened this issue Apr 3, 2020 · 2 comments
Closed

Names of resources created by the operator #139

fraborg opened this issue Apr 3, 2020 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/feature New feature or request sig/api

Comments

@fraborg
Copy link
Contributor

fraborg commented Apr 3, 2020

The name of the resources is based on the LabTemplate name, there are no checks of possible troublesome names (for example max length, accepted characters...) and also there are some mismatches in the resources names (for example the LabInstance has a random number different from the one of all other resources)

@fraborg fraborg mentioned this issue Apr 3, 2020
5 tasks
@fraborg fraborg added help wanted Extra attention is needed sig/api kind/feature New feature or request good first issue Good for newcomers labels Apr 3, 2020
@giorio94
Copy link
Member

giorio94 commented Oct 8, 2020

This problem has partially been addressed in #313. The name of the resources is now based on the one of the labinstance (instead of the labtemplate) with the addition of a random number. Yet, leaving open since the checks regarding troublesome names are still missing (at the moment, there is only a workaround in case a . is present).

@giorio94
Copy link
Member

Closing, as the name of the resources is now the one of the instance (#373)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/feature New feature or request sig/api
Projects
None yet
Development

No branches or pull requests

2 participants