Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Persistence #373

Merged
merged 1 commit into from
Mar 9, 2021
Merged

Conversation

AndreaGron
Copy link
Contributor

@AndreaGron AndreaGron commented Dec 13, 2020

Description

With this PR now it is possible to create persistent VM.
The instance controller has been updated in order to react to persistent template. A datavolume is created and it allows the creation of a pvc used to import the VM images.
It has been used a virtual machine instead of a virtual machine instance because of the need to start and stop the VMI.

@kingmakerbot
Copy link
Collaborator

Hi @AndreaGron. Thanks for your PR.

I am @kingmakerbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /deploy-staging: Deploy a staging environment to test this PR
  • /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@frisso
Copy link
Member

frisso commented Dec 14, 2020

Please take care of writing the proper description to your PR (starting with simple things such as "." at the end of a sentence, and capital letter at the beginning).
Persistance ==> Persistence
(a typo in the PR title looks a very bad start....)

@AndreaGron AndreaGron changed the title Support for Persistance Support for Persistence Dec 14, 2020
@giorio94 giorio94 added the kind/feature New feature or request label Dec 15, 2020
@kingmakerbot
Copy link
Collaborator

The generated files in the operators/ folder appear to be out-of-date.

Please, ensure you are using the correct version of controller-gen and re-run:

make generate
make manifests
Here it is an excerpt of the diff:
diff --git a/operators/go.mod b/operators/go.mod
index d30c26f..c2c92dc 100644
--- a/operators/go.mod
+++ b/operators/go.mod
@@ -24,6 +24,7 @@ require (
  k8s.io/klog v1.0.0
  k8s.io/utils v0.0.0-20201110183641-67b214c5f920
  kubevirt.io/client-go v0.35.0
+	kubevirt.io/containerized-data-importer v1.25.0
  sigs.k8s.io/controller-runtime v0.6.2
  sigs.k8s.io/controller-tools v0.4.1 // indirect
)

1 similar comment
@kingmakerbot
Copy link
Collaborator

The generated files in the operators/ folder appear to be out-of-date.

Please, ensure you are using the correct version of controller-gen and re-run:

make generate
make manifests
Here it is an excerpt of the diff:
diff --git a/operators/go.mod b/operators/go.mod
index d30c26f..c2c92dc 100644
--- a/operators/go.mod
+++ b/operators/go.mod
@@ -24,6 +24,7 @@ require (
  k8s.io/klog v1.0.0
  k8s.io/utils v0.0.0-20201110183641-67b214c5f920
  kubevirt.io/client-go v0.35.0
+	kubevirt.io/containerized-data-importer v1.25.0
  sigs.k8s.io/controller-runtime v0.6.2
  sigs.k8s.io/controller-tools v0.4.1 // indirect
)

@kingmakerbot
Copy link
Collaborator

The generated files in the operators/ folder appear to be out-of-date.

Please, ensure you are using the correct version of controller-gen and re-run:

make generate
make manifests
Here it is an excerpt of the diff:

README.md Outdated Show resolved Hide resolved
@AndreaGron
Copy link
Contributor Author

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly deployed/updated!

@AndreaGron AndreaGron force-pushed the master branch 3 times, most recently from a5a83a5 to 1e33b68 Compare March 5, 2021 11:17
@ste911
Copy link
Contributor

ste911 commented Mar 5, 2021

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly deployed/updated!

@AndreaGron AndreaGron force-pushed the master branch 3 times, most recently from 80562bd to 30fa3d2 Compare March 5, 2021 18:59
@ste911
Copy link
Contributor

ste911 commented Mar 5, 2021

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly deployed/updated!

@AndreaGron
Copy link
Contributor Author

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly deployed/updated!

@ste911
Copy link
Contributor

ste911 commented Mar 6, 2021

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly deployed/updated!

Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@giorio94
Copy link
Member

giorio94 commented Mar 9, 2021

/rebase

@giorio94
Copy link
Member

giorio94 commented Mar 9, 2021

/merge

@kingmakerbot kingmakerbot merged commit 27e3fa8 into netgroup-polito:master Mar 9, 2021
@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly teared-down!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants