-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Persistence #373
Conversation
Hi @AndreaGron. Thanks for your PR. I am @kingmakerbot.
Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:
|
Please take care of writing the proper description to your PR (starting with simple things such as "." at the end of a sentence, and capital letter at the beginning). |
The generated files in the Please, ensure you are using the correct version of
Here it is an excerpt of the diff:diff --git a/operators/go.mod b/operators/go.mod
index d30c26f..c2c92dc 100644
--- a/operators/go.mod
+++ b/operators/go.mod
@@ -24,6 +24,7 @@ require (
k8s.io/klog v1.0.0
k8s.io/utils v0.0.0-20201110183641-67b214c5f920
kubevirt.io/client-go v0.35.0
+ kubevirt.io/containerized-data-importer v1.25.0
sigs.k8s.io/controller-runtime v0.6.2
sigs.k8s.io/controller-tools v0.4.1 // indirect
) |
1 similar comment
The generated files in the Please, ensure you are using the correct version of
Here it is an excerpt of the diff:diff --git a/operators/go.mod b/operators/go.mod
index d30c26f..c2c92dc 100644
--- a/operators/go.mod
+++ b/operators/go.mod
@@ -24,6 +24,7 @@ require (
k8s.io/klog v1.0.0
k8s.io/utils v0.0.0-20201110183641-67b214c5f920
kubevirt.io/client-go v0.35.0
+ kubevirt.io/containerized-data-importer v1.25.0
sigs.k8s.io/controller-runtime v0.6.2
sigs.k8s.io/controller-tools v0.4.1 // indirect
) |
The generated files in the Please, ensure you are using the correct version of
Here it is an excerpt of the diff: |
50101d6
to
9721962
Compare
ae85cc8
to
0d10e92
Compare
/deploy-staging |
Your staging environment has been correctly deployed/updated!
|
a5a83a5
to
1e33b68
Compare
/deploy-staging |
Your staging environment has been correctly deployed/updated!
|
80562bd
to
30fa3d2
Compare
/deploy-staging |
Your staging environment has been correctly deployed/updated!
|
/deploy-staging |
Your staging environment has been correctly deployed/updated!
|
/deploy-staging |
Your staging environment has been correctly deployed/updated!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/rebase |
/merge |
Your staging environment has been correctly teared-down! |
Description
With this PR now it is possible to create persistent VM.
The instance controller has been updated in order to react to persistent template. A datavolume is created and it allows the creation of a pvc used to import the VM images.
It has been used a virtual machine instead of a virtual machine instance because of the need to start and stop the VMI.