Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend: user management form #600

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Frontend: user management form #600

merged 1 commit into from
Mar 9, 2022

Conversation

Ale142
Copy link
Collaborator

@Ale142 Ale142 commented Oct 6, 2021 •
edited

Description

This PR includes:

  • support for the backend with the UserListLogic component
  • the Autcompletition functionality in order to add already registered users.
  • modal with guided step for uploading users from CSV files

Co-authored by: Luca Errani luca.errani1@gmail.com

@Ale142 Ale142 requested a review from a team as a code owner October 6, 2021 09:38
@kingmakerbot
Copy link
Collaborator

Hi @Ale142. Thanks for your PR.

I am @kingmakerbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /hold: Adds hold label to prevent merging with /merge
  • /unhold: Removes the hold label to allow merging with /merge
  • /deploy-staging: Deploy a staging environment to test this PR
  • /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@Ale142
Copy link
Collaborator Author

Ale142 commented Oct 6, 2021

/rebase

@luco5826
Copy link
Contributor

luco5826 commented Oct 6, 2021

/rebase

@Ale142
Copy link
Collaborator Author

Ale142 commented Oct 9, 2021

/deploy-staging

@Ale142 Ale142 force-pushed the able/userlistlogic branch 2 times, most recently from 7c0f4bc to adf7d0c Compare October 9, 2021 13:46
@Ale142
Copy link
Collaborator Author

Ale142 commented Oct 9, 2021

I leave this video to show the feature of Autocompletition component.

userlistlogic-2021-10-09_15.36.24.mp4

@Ale142
Copy link
Collaborator Author

Ale142 commented Oct 11, 2021

/rebase

@giorio94
Copy link
Member

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly deployed/updated!
Available here: Current dashboard, New frontend, Storybook, Qlkube
Operators: add the crownlabs.polito.it/operator-selector=staging-600 label to your tenant.

@Ale142 Ale142 added the kind/feature New feature or request label Oct 12, 2021
@giorio94
Copy link
Member

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly deployed/updated!
Available here: Current dashboard, New frontend, Storybook, Qlkube
Operators: add the crownlabs.polito.it/operator-selector=staging-600 label to your tenant.

@Ale142 Ale142 force-pushed the able/userlistlogic branch 3 times, most recently from 9c25acf to 2c1b791 Compare October 17, 2021 15:37
@Ale142
Copy link
Collaborator Author

Ale142 commented Oct 17, 2021

/rebase

@giorio94
Copy link
Member

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly deployed/updated!
Available here: Current dashboard, New frontend, Storybook, Qlkube
Operators: add the crownlabs.polito.it/operator-selector=staging-600 label to your tenant.

@Ale142
Copy link
Collaborator Author

Ale142 commented Oct 17, 2021

/rebase

QcFe
QcFe reviewed Feb 18, 2022
View reviewed changes
Copy link
Collaborator

@QcFe QcFe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase, will make another test run as soon as possible

frontend/src/utils.ts Show resolved Hide resolved
frontend/src/components/accountPage/UploadProgressModal/EditableTable.tsx Outdated Show resolved Hide resolved
@giorio94
Copy link
Member

/undeploy-staging

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly teared-down!

@QcFe
Copy link
Collaborator

QcFe commented Feb 25, 2022

/rebase

@Ale142 Ale142 force-pushed the able/userlistlogic branch 2 times, most recently from a50558b to 5cdc703 Compare February 25, 2022 14:17
@QcFe
Copy link
Collaborator

QcFe commented Mar 3, 2022

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly deployed/updated!
Available here: Frontend, Storybook, Qlkube
Operators: add the crownlabs.polito.it/operator-selector=staging-600 label to your tenant.

@giorio94
Copy link
Member

giorio94 commented Mar 4, 2022

/rebase

@giorio94
Copy link
Member

giorio94 commented Mar 4, 2022

/deploy-staging

@giorio94
Copy link
Member

giorio94 commented Mar 9, 2022

/rebase

@giorio94
Copy link
Member

giorio94 commented Mar 9, 2022

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly deployed/updated!
Available here: Frontend, Storybook, Qlkube
Operators: add the crownlabs.polito.it/operator-selector=staging-600 label to your tenant.

@giorio94
Copy link
Member

giorio94 commented Mar 9, 2022

/merge

@giorio94 giorio94 changed the title UserList Autocomplete + UserListLogic Frontend: user management form Mar 9, 2022
@giorio94 giorio94 added kind/feature New feature or request and removed hold Prevent bot merging labels Mar 9, 2022
@giorio94
Copy link
Member

giorio94 commented Mar 9, 2022

/merge

@kingmakerbot kingmakerbot merged commit 3cadc5c into netgroup-polito:master Mar 9, 2022
@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly teared-down!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QcFe QcFe QcFe left review comments

@giorio94 giorio94 giorio94 approved these changes

Assignees
No one assigned
Labels
kind/feature New feature or request sig/ui size/XXL
Projects
Frontend
In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Ale142 @kingmakerbot @luco5826 @giorio94 @QcFe