Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Selective group destroy #714

Merged
merged 2 commits into from
Apr 8, 2022
Merged

Added Selective group destroy #714

merged 2 commits into from
Apr 8, 2022

Conversation

cannarelladev
Copy link
Member

Description

This PR adds the possibility to select a group of instances to be destroyed

@kingmakerbot
Copy link
Collaborator

Hi @cannarelladev. Thanks for your PR.

I am @kingmakerbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /hold: Adds hold label to prevent merging with /merge
  • /unhold: Removes the hold label to allow merging with /merge
  • /deploy-staging: Deploy a staging environment to test this PR
  • /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cannarelladev cannarelladev added the kind/feature New feature or request label Dec 24, 2021
@QcFe QcFe added this to In progress in Frontend Jan 8, 2022
@cannarelladev cannarelladev force-pushed the alcfrc/ActivePageSelectiveDestroy branch 3 times, most recently from fbf078e to ac81421 Compare January 14, 2022 14:33
@cannarelladev cannarelladev force-pushed the alcfrc/ActivePageSelectiveDestroy branch from ac81421 to 3062853 Compare January 14, 2022 14:36
@cannarelladev cannarelladev force-pushed the alcfrc/ActivePageSelectiveDestroy branch from 3062853 to d0c8385 Compare January 19, 2022 16:43
@cannarelladev cannarelladev force-pushed the alcfrc/ActivePageSelectiveDestroy branch from d0c8385 to 2d55d66 Compare February 23, 2022 13:41
@cannarelladev cannarelladev force-pushed the alcfrc/ActivePageSelectiveDestroy branch from e1087bc to c7fc5f9 Compare March 2, 2022 16:57
@pull-request-size pull-request-size bot added size/L and removed size/XL labels Mar 2, 2022
@cannarelladev cannarelladev force-pushed the alcfrc/ActivePageSelectiveDestroy branch 4 times, most recently from f9b05f6 to 3b9afac Compare March 11, 2022 08:21
@cannarelladev cannarelladev force-pushed the alcfrc/ActivePageSelectiveDestroy branch from 3b9afac to 94686f1 Compare March 11, 2022 08:28
@cannarelladev cannarelladev force-pushed the alcfrc/ActivePageSelectiveDestroy branch 3 times, most recently from 2cbd45f to 97f1899 Compare April 6, 2022 08:21
@cannarelladev
Copy link
Member Author

/deploy-staging

@cannarelladev
Copy link
Member Author

@QcFe maybe we are ready

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly deployed/updated!
Available here: Frontend, Storybook, Qlkube
Operators: add the crownlabs.polito.it/operator-selector=staging-714 label to your tenant.

QcFe
QcFe approved these changes Apr 6, 2022
View reviewed changes
Copy link
Collaborator

@QcFe QcFe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more bits :)

frontend/src/components/activePage/TableInstance/TableInstance.tsx Show resolved Hide resolved
frontend/src/components/activePage/TableInstance/TableInstance.tsx Outdated Show resolved Hide resolved
frontend/src/components/activePage/TableWorkspace/TableWorkspace.tsx Outdated Show resolved Hide resolved
frontend/src/components/activePage/TableWorkspaceLogic/TableWorkspaceLogic.tsx Outdated Show resolved Hide resolved
@cannarelladev cannarelladev force-pushed the alcfrc/ActivePageSelectiveDestroy branch from 97f1899 to 61d5247 Compare April 6, 2022 13:09
@cannarelladev cannarelladev added hold Prevent bot merging and removed hold Prevent bot merging labels Apr 6, 2022
@QcFe
Copy link
Collaborator

QcFe commented Apr 6, 2022

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly deployed/updated!
Available here: Frontend, Storybook, Qlkube
Operators: add the crownlabs.polito.it/operator-selector=staging-714 label to your tenant.

@cannarelladev
Copy link
Member Author

/rebase

@cannarelladev
Copy link
Member Author

/deploy-staging

@kingmakerbot kingmakerbot force-pushed the alcfrc/ActivePageSelectiveDestroy branch from 61d5247 to dc92ef3 Compare April 6, 2022 17:58
@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly deployed/updated!
Available here: Frontend, Storybook, Qlkube
Operators: add the crownlabs.polito.it/operator-selector=staging-714 label to your tenant.

@cannarelladev cannarelladev force-pushed the alcfrc/ActivePageSelectiveDestroy branch 2 times, most recently from b5cb9d1 to efa5ebe Compare April 7, 2022 07:23
@cannarelladev
Copy link
Member Author

/rebase

@kingmakerbot kingmakerbot force-pushed the alcfrc/ActivePageSelectiveDestroy branch from 82deaeb to 5a0f200 Compare April 7, 2022 08:08
@cannarelladev
Copy link
Member Author

/deploy-staging

cannarelladev and others added 2 commits April 8, 2022 09:53
@cannarelladev @cheina97
Added Selective group destroy
265670a 
Co-authored-by: Francesco Cheinasso <cheinasso.francesco@gmail.com>
@cannarelladev @cheina97
New Toolbox component for future extended functionalities
4c7836a 
Co-authored-by: Francesco Cheinasso <cheinasso.francesco@gmail.com>
@cannarelladev cannarelladev force-pushed the alcfrc/ActivePageSelectiveDestroy branch from 5a0f200 to 4c7836a Compare April 8, 2022 07:53
@QcFe
Copy link
Collaborator

QcFe commented Apr 8, 2022

/merge

@kingmakerbot kingmakerbot merged commit 4c55a08 into netgroup-polito:master Apr 8, 2022
@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly teared-down!

@cheina97 cheina97 deleted the alcfrc/ActivePageSelectiveDestroy branch April 26, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QcFe QcFe QcFe approved these changes

Assignees
No one assigned
Labels
kind/feature New feature or request sig/api sig/devops sig/ui size/XL
Projects
Frontend
In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cannarelladev @kingmakerbot @QcFe