Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standalone applications #716

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Standalone applications #716

merged 1 commit into from
Mar 17, 2022

Conversation

cheina97
Copy link
Member

@cheina97 cheina97 commented Dec 27, 2021 •
edited

This PR introduces the possibility to deploy a generic web-based application on CrownLabs using templates and instances.

Roadmap:

  • Add Standalone EnvironmentType to the CRD
  • Implement the creation of a standalone application's Ingress in the instance controller
  • Add the Rewrite annotation to the ingress to allow the deploying of applications with a generic subpath
  • Implement the creation of a standalone application's Service in the instance controller
  • Implement a new Pod creation function for standalone applications in the instance controller
  • Clean the code

@cheina97 cheina97 requested a review from a team as a code owner December 27, 2021 00:24
@kingmakerbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR.

I am @kingmakerbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /hold: Adds hold label to prevent merging with /merge
  • /unhold: Removes the hold label to allow merging with /merge
  • /deploy-staging: Deploy a staging environment to test this PR
  • /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97 cheina97 changed the title Alcfrc/standalone container Standalone applications Dec 27, 2021
@cheina97 cheina97 force-pushed the alcfrc/standaloneContainer branch 3 times, most recently from db9d5ff to 9bcc0a1 Compare December 27, 2021 00:32
@cheina97 cheina97 marked this pull request as draft December 27, 2021 00:32
@cheina97 cheina97 added kind/docs Improvements or additions to documentation and removed kind/docs Improvements or additions to documentation labels Jan 5, 2022
@cheina97
Copy link
Member Author

cheina97 commented Jan 5, 2022

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly deployed/updated!
Available here: Frontend, Storybook, Qlkube
Operators: add the crownlabs.polito.it/operator-selector=staging-716 label to your tenant.

@cheina97 cheina97 marked this pull request as ready for review January 5, 2022 12:59
@cheina97 cheina97 force-pushed the alcfrc/standaloneContainer branch 12 times, most recently from fee6c5a to 7ef4e43 Compare January 6, 2022 18:04
@cheina97 cheina97 marked this pull request as draft January 7, 2022 18:31
giorio94
giorio94 reviewed Mar 14, 2022
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
operators/Makefile Outdated Show resolved Hide resolved
operators/Makefile Show resolved Hide resolved
operators/Makefile Outdated Show resolved Hide resolved
operators/samples/instance.yaml Outdated Show resolved Hide resolved
operators/pkg/forge/ingresses.go Outdated Show resolved Hide resolved
operators/pkg/forge/ingresses.go Outdated Show resolved Hide resolved
operators/pkg/forge/ingresses_test.go Outdated Show resolved Hide resolved
@cheina97
Copy link
Member Author

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly deployed/updated!
Available here: Frontend, Storybook, Qlkube
Operators: add the crownlabs.polito.it/operator-selector=staging-716 label to your tenant.

@cheina97 cheina97 force-pushed the alcfrc/standaloneContainer branch 5 times, most recently from 3067fe0 to 0b953c8 Compare March 15, 2022 17:25
@giorio94
Copy link
Member

/rebase

giorio94
giorio94 approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more comments, I promise

operators/pkg/forge/ingresses_test.go Outdated Show resolved Hide resolved
operators/pkg/forge/ingresses_test.go Outdated Show resolved Hide resolved
operators/pkg/forge/ingresses_test.go Outdated Show resolved Hide resolved
operators/pkg/forge/ingresses_test.go Outdated Show resolved Hide resolved
operators/samples/templates.yaml Outdated Show resolved Hide resolved
operators/samples/templates.yaml Outdated Show resolved Hide resolved
operators/pkg/forge/ingresses.go Outdated Show resolved Hide resolved
@cheina97 cheina97 force-pushed the alcfrc/standaloneContainer branch 2 times, most recently from 670d04c to c858e44 Compare March 15, 2022 23:17
@cannarelladev cannarelladev mentioned this pull request Mar 16, 2022
Merged
@cannarelladev cannarelladev force-pushed the alcfrc/standaloneContainer branch 2 times, most recently from 8dc2a1e to 7f0e125 Compare March 16, 2022 11:26
@cheina97
Copy link
Member Author

/rebase

@cheina97 @cannarelladev
Added Standalone applications
9e0a1b4 
Co-authored-by: Alessandro Cannarella <cannarella.dev@gmail.com>
@giorio94
Copy link
Member

/merge

@kingmakerbot kingmakerbot merged commit 4bfa563 into netgroup-polito:master Mar 17, 2022
@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly teared-down!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cannarelladev cannarelladev cannarelladev left review comments

@giorio94 giorio94 giorio94 approved these changes

Assignees
No one assigned
Labels
kind/feature New feature or request sig/api sig/devops sig/ui size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cheina97 @kingmakerbot @giorio94 @cannarelladev