Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Standalone Containers #720

Merged
merged 2 commits into from
Apr 22, 2022
Merged

Custom Standalone Containers #720

merged 2 commits into from
Apr 22, 2022

Conversation

cheina97
Copy link
Member

@cheina97 cheina97 commented Jan 7, 2022

Thos PR adds the standalone images folder in provisioning and some custom images Dockerfile for vscode

@cheina97 cheina97 requested a review from a team as a code owner January 7, 2022 11:27
@kingmakerbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR.

I am @kingmakerbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /hold: Adds hold label to prevent merging with /merge
  • /unhold: Removes the hold label to allow merging with /merge
  • /deploy-staging: Deploy a staging environment to test this PR
  • /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97 cheina97 changed the title Added Custom VScode container Custom Standalone Containers Jan 7, 2022
@cheina97 cheina97 marked this pull request as draft January 7, 2022 11:37
@cheina97 cheina97 force-pushed the alcfrc/customVscodeContainer branch 21 times, most recently from 2090edc to 97198b0 Compare January 9, 2022 10:35
@pull-request-size pull-request-size bot added size/XL and removed size/L labels Jan 9, 2022
@cheina97 cheina97 force-pushed the alcfrc/customVscodeContainer branch 2 times, most recently from b54e605 to cf03fb5 Compare January 9, 2022 11:22
@pull-request-size pull-request-size bot added size/XL and removed size/L labels Apr 7, 2022
@cheina97 cheina97 force-pushed the alcfrc/customVscodeContainer branch from 0e6ab6e to b402cd9 Compare April 7, 2022 21:46
@pull-request-size pull-request-size bot added size/L and removed size/XL labels Apr 7, 2022
@cheina97 cheina97 requested a review from giorio94 April 11, 2022 16:40
@giorio94
Copy link
Member

/rebase

@giorio94 giorio94 added the kind/feature New feature or request label Apr 15, 2022
giorio94
giorio94 reviewed Apr 15, 2022
View reviewed changes
Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few additional (minor) comments. In addition, a great improvement would be to add a few comments as here.

.github/workflows/build-matrix.json Outdated Show resolved Hide resolved
provisioning/standalone/jupyterlab/Dockerfile Outdated Show resolved Hide resolved
provisioning/standalone/jupyterlab/Dockerfile Outdated Show resolved Hide resolved
provisioning/standalone/jupyterlab/Dockerfile Outdated Show resolved Hide resolved
provisioning/standalone/jupyterlab/adduser.sh Outdated Show resolved Hide resolved
provisioning/standalone/vscode/c-cpp/Dockerfile Outdated Show resolved Hide resolved
provisioning/standalone/vscode/c-cpp/project/main.c Outdated Show resolved Hide resolved
provisioning/standalone/vscode/python/Dockerfile Outdated Show resolved Hide resolved
provisioning/standalone/vscode/python/Dockerfile Outdated Show resolved Hide resolved
provisioning/standalone/vscode/python/project/main.py Outdated Show resolved Hide resolved
@cheina97 cheina97 force-pushed the alcfrc/customVscodeContainer branch from b402cd9 to 6f16846 Compare April 16, 2022 23:01
@cheina97 @cannarelladev
Added Standaone Containers
7101faa 
Co-authored-by: Alessandro Cannarella <cannarella.dev@gmail.com>
@cheina97 cheina97 force-pushed the alcfrc/customVscodeContainer branch 4 times, most recently from 35f05f6 to 3ddaa37 Compare April 20, 2022 18:32
giorio94
giorio94 approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm Just a few nits inline.

provisioning/standalone/jupyterlab/Dockerfile Outdated Show resolved Hide resolved
provisioning/standalone/jupyterlab/Dockerfile Outdated Show resolved Hide resolved
provisioning/standalone/vscode/base/Dockerfile Outdated Show resolved Hide resolved
provisioning/standalone/vscode/base/Dockerfile Outdated Show resolved Hide resolved
provisioning/standalone/vscode/base/Dockerfile Outdated Show resolved Hide resolved
provisioning/standalone/vscode/base/start.sh Outdated Show resolved Hide resolved
provisioning/standalone/vscode/base/start.sh Show resolved Hide resolved
provisioning/standalone/vscode/c-cpp/Dockerfile Outdated Show resolved Hide resolved
@cheina97 cheina97 force-pushed the alcfrc/customVscodeContainer branch from 3ddaa37 to e385dde Compare April 21, 2022 20:17
@cannarelladev cannarelladev force-pushed the alcfrc/customVscodeContainer branch 2 times, most recently from 595e4b8 to 67e5889 Compare April 22, 2022 07:03
@cheina97 cheina97 force-pushed the alcfrc/customVscodeContainer branch from 67e5889 to e385dde Compare April 22, 2022 07:10
@cheina97 cheina97 force-pushed the alcfrc/customVscodeContainer branch from 67e5889 to 80bc4f4 Compare April 22, 2022 07:21
@cheina97
Copy link
Member Author

/merge

@kingmakerbot kingmakerbot merged commit d739cdb into netgroup-polito:master Apr 22, 2022
@cheina97 cheina97 deleted the alcfrc/customVscodeContainer branch April 22, 2022 07:26
@cheina97 cheina97 restored the alcfrc/customVscodeContainer branch April 22, 2022 07:38
@cheina97 cheina97 deleted the alcfrc/customVscodeContainer branch April 22, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cannarelladev cannarelladev cannarelladev left review comments

@giorio94 giorio94 giorio94 approved these changes

Assignees
No one assigned
Labels
kind/feature New feature or request sig/api sig/devops sig/operations sig/ui size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cheina97 @kingmakerbot @giorio94 @cannarelladev