Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Harbor GituHub Actions #757

Merged
merged 1 commit into from
Feb 21, 2022
Merged

Add Harbor GituHub Actions #757

merged 1 commit into from
Feb 21, 2022

Conversation

s225904
Copy link
Collaborator

@s225904 s225904 commented Feb 17, 2022

Description

Change build.yml file in workflow directory, adding github action for Harbor. Update also the DockerHub docker/build-push-action@v2 part because the issue 252 has been update

How Has This Been Tested?

I've run this workflow many times and I've seen that the github actions when successfully ends push the images in the correct project. Unfortunately there is a problem with the robot account and some times a random github actions fail.

@s225904 s225904 requested a review from a team as a code owner February 17, 2022 11:07
@kingmakerbot
Copy link
Collaborator

Hi @s225904. Thanks for your PR.

I am @kingmakerbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /hold: Adds hold label to prevent merging with /merge
  • /unhold: Removes the hold label to allow merging with /merge
  • /deploy-staging: Deploy a staging environment to test this PR
  • /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@giorio94 giorio94 added the kind/feature New feature or request label Feb 17, 2022
@giorio94 giorio94 marked this pull request as draft February 17, 2022 13:08
@s225904 s225904 changed the title Giuse/registry Add Harbor GituHub Actions Feb 18, 2022
@pull-request-size pull-request-size bot added size/M and removed size/L labels Feb 18, 2022
@s225904 s225904 marked this pull request as ready for review February 18, 2022 16:28
Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments inline

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
@giorio94
Copy link
Member

/rebase

Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment. Remember also to squash the commits

.github/workflows/build.yml Outdated Show resolved Hide resolved
fix comment

Add Harbor GitHub actions to build.yml in workflow directory

Update build.yml

add Harbor Login

Update build.yml

add build and push for harbor

Update build.yml

change secret to secrets

Update build.yml

change tags of harbor push

Update build.yml

test for pushing in repo crownlabs

Update build.yml

add docker login

Update build.yml

add cache docker layers

Update build.yml

without layers

Update build.yml

one Docker Buildx

Update build.yml

add cache action for harbor

Update build.yml

add checkout to harbor

Update build.yml

build and push in specific project

Update build.yml

fix if

Update build.yml

fix if statement with matrix.component

Update build.yml

remove parentesis {{ }} from if statement

Update build.yml

Update build.yml

Update build.yml

Update build.yml

fix if statement

Update build.yml

final fix

Update build.yml

change local cache into gha

Update build.yml

update issue 252 for cache in DockerHub part

Update build.yml

fix after call

Update build.yml

comment DockerHub tag

delete repo-owner for harbor

fix harbor-project in tags

hardcoded value changed with the secret

secret changed
Copy link
Collaborator Author

@s225904 s225904 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@giorio94
Copy link
Member

/merge

@kingmakerbot kingmakerbot merged commit 7b06dbe into master Feb 21, 2022
@kingmakerbot kingmakerbot deleted the giuse/registry branch February 21, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants