Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend: New modal for Instance group deletion #767

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Frontend: New modal for Instance group deletion #767

merged 1 commit into from
Nov 3, 2022

Conversation

cannarelladev
Copy link
Member

@cannarelladev cannarelladev commented Mar 16, 2022 •
edited

With this PR will be implement and improve the system and the modal to delete a certain group of instances:

  • Active Page [Manager]: Selective group deletion
  • Active Page [Manager]: Group deletion by "Template"
  • Active Page [Personal]: Delete all personal instances (Persistent ones won't be deleted anymore)
  • Simple deletion modal restyling

@kingmakerbot
Copy link
Collaborator

Hi @cannarelladev. Thanks for your PR.

I am @kingmakerbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /hold: Adds hold label to prevent merging with /merge
  • /unhold: Removes the hold label to allow merging with /merge
  • /deploy-staging: Deploy a staging environment to test this PR
  • /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cannarelladev cannarelladev added this to In progress in Frontend Mar 16, 2022
@cannarelladev cannarelladev force-pushed the alcfrc/modalGroupDeletion branch 2 times, most recently from fbca5cf to 59ae7ee Compare June 21, 2022 12:21
@cannarelladev
Copy link
Member Author

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly deployed/updated!
Available here: Frontend, Qlkube
Operators: add the crownlabs.polito.it/operator-selector=staging-767 label to your tenant.

@pull-request-size pull-request-size bot added size/XL and removed size/L labels Jul 6, 2022
@cheina97
Copy link
Member

cheina97 commented Jul 6, 2022

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly deployed/updated!
Available here: Frontend, Qlkube
Operators: add the crownlabs.polito.it/operator-selector=staging-767 label to your tenant.

@cannarelladev cannarelladev marked this pull request as ready for review October 19, 2022 12:53
@cannarelladev cannarelladev requested a review from a team as a code owner October 19, 2022 12:53
@cannarelladev
Copy link
Member Author

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly deployed/updated!
Available here: Frontend, Qlkube
Operators: add the crownlabs.polito.it/operator-selector=staging-767 label to your tenant.

QcFe
QcFe reviewed Oct 19, 2022
View reviewed changes
Copy link
Collaborator

@QcFe QcFe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some random suggestions

frontend/src/utilsLogic.tsx Outdated Show resolved Hide resolved
frontend/src/utilsLogic.tsx Show resolved Hide resolved
frontend/src/components/workspaces/Templates/TemplatesTableLogic/TemplatesTableLogic.tsx Outdated Show resolved Hide resolved
frontend/src/components/workspaces/Templates/TemplatesTableLogic/TemplatesTableLogic.tsx Outdated Show resolved Hide resolved
frontend/src/components/activePage/ActiveViewLogic/ActiveViewLogic.tsx Outdated Show resolved Hide resolved
@giorio94 giorio94 added the kind/bug Something isn't working label Oct 19, 2022
@cannarelladev
Copy link
Member Author

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly deployed/updated!
Available here: Frontend, Qlkube
Operators: add the crownlabs.polito.it/operator-selector=staging-767 label to your tenant.

QcFe
QcFe reviewed Oct 25, 2022
View reviewed changes
Copy link
Collaborator

@QcFe QcFe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly stylistic issues, one comment is more concerning though

frontend/src/components/activePage/TableInstance/TableInstance.tsx Show resolved Hide resolved
frontend/src/components/activePage/TableInstance/TableInstance.tsx Outdated Show resolved Hide resolved
frontend/src/components/activePage/TableInstance/TableInstance.tsx Outdated Show resolved Hide resolved
frontend/src/components/activePage/TableTemplate/TableTemplateRow.tsx Outdated Show resolved Hide resolved
frontend/src/components/activePage/TableInstance/TableInstance.tsx Outdated Show resolved Hide resolved
frontend/src/components/activePage/TableInstance/TableInstance.tsx Outdated Show resolved Hide resolved
@cannarelladev
Frontend: New deletion modals, some UI and Logic bugfix
e63895a 
Co-authored-by: Francesco Cheinasso <cheinasso.francesco@gmail.com>
@cannarelladev
Copy link
Member Author

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly deployed/updated!
Available here: Frontend, Qlkube
Operators: add the crownlabs.polito.it/operator-selector=staging-767 label to your tenant.

@QcFe
Copy link
Collaborator

QcFe commented Nov 3, 2022

/merge

@kingmakerbot kingmakerbot merged commit 5e71b7d into netgroup-polito:master Nov 3, 2022
@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly teared-down!

@giorio94 giorio94 added kind/feature New feature or request and removed kind/bug Something isn't working labels Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QcFe QcFe QcFe approved these changes

Assignees
No one assigned
Labels
kind/feature New feature or request sig/ui size/XL
Projects
Frontend
In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cannarelladev @kingmakerbot @cheina97 @QcFe @giorio94