Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub actions: externalize build matrix #773

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

giorio94
Copy link
Member

@giorio94 giorio94 commented Apr 2, 2022

Description

This PR modifies the build workflow, to enable a more granular control on which containers are build depending on the triggering event. Specifically, the matrix definition is moved to an external json file, that is read and optionally filtered by a custom action during the pre-processing step. The current configuration ensures that all the core images are always built, while user environments are built only in case of stable releases and if the /deploy-staging command is triggered with an appropriate flag.

How Has This Been Tested?

  • Checking the correct functioning of the workflow on a personal fork.

@giorio94 giorio94 added the kind/feature New feature or request label Apr 2, 2022
@giorio94 giorio94 requested a review from QcFe April 2, 2022 13:33
@giorio94 giorio94 requested a review from a team as a code owner April 2, 2022 13:33
@kingmakerbot
Copy link
Collaborator

Hi @giorio94. Thanks for your PR.

I am @kingmakerbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /hold: Adds hold label to prevent merging with /merge
  • /unhold: Removes the hold label to allow merging with /merge
  • /deploy-staging: Deploy a staging environment to test this PR
  • /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@giorio94
Copy link
Member Author

giorio94 commented Apr 6, 2022

/rebase

@giorio94
Copy link
Member Author

giorio94 commented Apr 7, 2022

/merge

@kingmakerbot kingmakerbot merged commit 3afd5fa into netgroup-polito:master Apr 7, 2022
@giorio94 giorio94 deleted the mio/build-matrix branch January 6, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants