Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing storybook dependencies, files and workflows #775

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Removing storybook dependencies, files and workflows #775

merged 1 commit into from
Apr 7, 2022

Conversation

cannarelladev
Copy link
Member

Description

In this PR storybook is definitely remoded:

  • Build and workflows
  • Dependencies
  • Story files

@cannarelladev cannarelladev requested a review from a team as a code owner April 6, 2022 08:41
@kingmakerbot
Copy link
Collaborator

Hi @cannarelladev. Thanks for your PR.

I am @kingmakerbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /hold: Adds hold label to prevent merging with /merge
  • /unhold: Removes the hold label to allow merging with /merge
  • /deploy-staging: Deploy a staging environment to test this PR
  • /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cannarelladev
Copy link
Member Author

@giorio94 could you check if everything is right on latest commit of this PR? the other commits belong to and old PR that is going to be merged

@cannarelladev cannarelladev added kind/docs Improvements or additions to documentation kind/cleanup Refactoring code labels Apr 6, 2022
@cannarelladev cannarelladev changed the title Alcfrc/remove storybook Removing storybook dependencies, files and workflows Apr 6, 2022
@cannarelladev cannarelladev force-pushed the alcfrc/RemoveStorybook branch 2 times, most recently from 484df11 to e0831a1 Compare April 7, 2022 07:13
@giorio94
Copy link
Member

giorio94 commented Apr 7, 2022

/merge

@kingmakerbot kingmakerbot merged commit fde2012 into netgroup-polito:master Apr 7, 2022
@cheina97 cheina97 deleted the alcfrc/RemoveStorybook branch April 26, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giorio94 giorio94 giorio94 approved these changes

Assignees
No one assigned
Labels
kind/cleanup Refactoring code kind/docs Improvements or additions to documentation sig/devops sig/ui size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cannarelladev @kingmakerbot @giorio94