Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend: Cumulative bug fix #777

Merged

Conversation

cannarelladev
Copy link
Member

@cannarelladev cannarelladev commented Apr 8, 2022

Description

This PR includes a number of frontend UX bug fixes and solves some logic issues

  • Light Theme: notification bug
  • Instances data mapping
  • React component key issues
  • other

@kingmakerbot
Copy link
Collaborator

Hi @cannarelladev. Thanks for your PR.

I am @kingmakerbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /hold: Adds hold label to prevent merging with /merge
  • /unhold: Removes the hold label to allow merging with /merge
  • /deploy-staging: Deploy a staging environment to test this PR (the build-all flag enables user environments building)
  • /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cannarelladev cannarelladev added the kind/bug Something isn't working label Apr 8, 2022
@cannarelladev cannarelladev marked this pull request as ready for review May 25, 2022 13:04
@cannarelladev cannarelladev requested a review from a team as a code owner May 25, 2022 13:04
@QcFe
Copy link
Collaborator

QcFe commented May 25, 2022

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly deployed/updated!
Available here: Frontend, Qlkube
Operators: add the crownlabs.polito.it/operator-selector=staging-777 label to your tenant.

@QcFe
Copy link
Collaborator

QcFe commented May 25, 2022

/merge

@kingmakerbot kingmakerbot merged commit 4ee1611 into netgroup-polito:master May 25, 2022
@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly teared-down!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working sig/ui size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants