Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Standalone documentation #779

Conversation

cheina97
Copy link
Member

@cheina97 cheina97 commented Apr 16, 2022

This PR adds the documentation about Standalone Applications.

In particular, it contains:

  • an explanation about what are Standalone Applications.
  • the requirements that a Standalone Application has to respect in order to be deployed successfully.
  • an example that describes step by step how to create a Standalone Application and deploy it.
  • the documentation about code-server
  • how to customize and deploy code-server

@kingmakerbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR.

I am @kingmakerbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /hold: Adds hold label to prevent merging with /merge
  • /unhold: Removes the hold label to allow merging with /merge
  • /deploy-staging: Deploy a staging environment to test this PR (the build-all flag enables user environments building)
  • /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97 cheina97 force-pushed the alcfrc/standaloneDocumentation branch from 95c6a43 to bb7a2cc Compare April 16, 2022 23:02
@cheina97 cheina97 force-pushed the alcfrc/standaloneDocumentation branch from bb7a2cc to 8f0f58d Compare April 16, 2022 23:03
@cheina97 cheina97 added the kind/docs Improvements or additions to documentation label Apr 16, 2022
@cheina97 cheina97 force-pushed the alcfrc/standaloneDocumentation branch from 8f0f58d to b1c837d Compare April 16, 2022 23:23
@cheina97 cheina97 force-pushed the alcfrc/standaloneDocumentation branch from 11aa0f5 to 89ea76b Compare April 16, 2022 23:26
@cheina97 cheina97 force-pushed the alcfrc/standaloneDocumentation branch 3 times, most recently from ff04d86 to 4e91690 Compare April 20, 2022 13:25
@cheina97 cheina97 force-pushed the alcfrc/standaloneDocumentation branch 8 times, most recently from b45cee3 to ce0633c Compare April 22, 2022 07:30
@cheina97 cheina97 force-pushed the alcfrc/standaloneDocumentation branch 3 times, most recently from a304e61 to 1e99269 Compare April 27, 2022 17:11
@cannarelladev cannarelladev force-pushed the alcfrc/standaloneDocumentation branch 7 times, most recently from de398c9 to c6665d0 Compare April 28, 2022 05:15
@cannarelladev cannarelladev marked this pull request as ready for review April 28, 2022 05:15
@cannarelladev cannarelladev requested a review from a team as a code owner April 28, 2022 05:15
@cannarelladev cannarelladev force-pushed the alcfrc/standaloneDocumentation branch 2 times, most recently from 0991658 to 70f82bf Compare April 28, 2022 05:19
@cheina97 cheina97 force-pushed the alcfrc/standaloneDocumentation branch from 70f82bf to 3084154 Compare April 28, 2022 23:09
@cheina97 cheina97 requested a review from giorio94 May 3, 2022 08:38
@cheina97 cheina97 force-pushed the alcfrc/standaloneDocumentation branch from 3084154 to 576ab5a Compare May 8, 2022 23:04
Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review.

A few comments inline, but overall looks mostly good to me.

provisioning/README.md Outdated Show resolved Hide resolved
provisioning/standalone/README.md Outdated Show resolved Hide resolved
provisioning/standalone/README.md Outdated Show resolved Hide resolved
provisioning/standalone/README.md Outdated Show resolved Hide resolved
provisioning/standalone/README.md Outdated Show resolved Hide resolved
provisioning/standalone/vscode/README.md Show resolved Hide resolved
provisioning/standalone/vscode/README.md Outdated Show resolved Hide resolved
provisioning/standalone/vscode/README.md Outdated Show resolved Hide resolved
provisioning/standalone/vscode/README.md Outdated Show resolved Hide resolved
provisioning/standalone/vscode/README.md Outdated Show resolved Hide resolved
@cheina97 cheina97 force-pushed the alcfrc/standaloneDocumentation branch from 508691c to e821b54 Compare May 17, 2022 07:40
Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Just a couple of final comments, then feel free to squash and merge

@cheina97 cheina97 force-pushed the alcfrc/standaloneDocumentation branch 2 times, most recently from 6a8c169 to ef2c727 Compare May 23, 2022 07:33
Co-authored-by: Alessandro Cannarella <cannarella.dev@gmail.com>
@cheina97 cheina97 force-pushed the alcfrc/standaloneDocumentation branch from ef2c727 to 015b627 Compare May 23, 2022 07:36
@cheina97
Copy link
Member Author

/merge

@kingmakerbot kingmakerbot merged commit 052a0ed into netgroup-polito:master May 23, 2022
@cheina97 cheina97 deleted the alcfrc/standaloneDocumentation branch May 23, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/docs Improvements or additions to documentation sig/devops size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants