Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar Fix #782

Merged
merged 1 commit into from
Apr 27, 2022
Merged

Conversation

cheina97
Copy link
Member

This PR fix the Navbar issue where multiple tabs were opened on some browsers

@cheina97 cheina97 added kind/bug Something isn't working sig/ui labels Apr 26, 2022
@cheina97 cheina97 requested a review from a team as a code owner April 26, 2022 20:35
@kingmakerbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR.

I am @kingmakerbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /hold: Adds hold label to prevent merging with /merge
  • /unhold: Removes the hold label to allow merging with /merge
  • /deploy-staging: Deploy a staging environment to test this PR (the build-all flag enables user environments building)
  • /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

Co-authored-by: Alessandro Cannarella <cannarella.dev@gmail.com>
@cheina97
Copy link
Member Author

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly deployed/updated!
Available here: Frontend, Qlkube
Operators: add the crownlabs.polito.it/operator-selector=staging-782 label to your tenant.

@cheina97
Copy link
Member Author

/merge

@kingmakerbot kingmakerbot merged commit 9e28062 into netgroup-polito:master Apr 27, 2022
@cheina97 cheina97 deleted the alcfrc/NavbarFix branch April 27, 2022 07:04
@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly teared-down!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working sig/ui size/XS
Projects
Frontend
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

3 participants