-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Student insertion from csv: fix issue with (**) #817
Merged
kingmakerbot
merged 1 commit into
netgroup-polito:master
from
giorio94:mio/fix-student-insertion
Nov 17, 2022
Merged
Student insertion from csv: fix issue with (**) #817
kingmakerbot
merged 1 commit into
netgroup-polito:master
from
giorio94:mio/fix-student-insertion
Nov 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/deploy-staging |
Hi @giorio94. Thanks for your PR. I am @kingmakerbot.
Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:
|
04779ed
to
4a521a4
Compare
/deploy-staging |
QcFe
approved these changes
Nov 17, 2022
/merge |
Your staging environment has been correctly teared-down! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue concerning students' insertion from CSV, which occurs when the surname contains the
(**)
string (used by the portal to signal certain conditions). This includes the frontend, to appropriately remove it, and the backend, to prevent issues with names that end with a space (after the removal of invalid characters).How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.