Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Student insertion from csv: fix issue with (**) #817

Merged

Conversation

giorio94
Copy link
Member

@giorio94 giorio94 commented Nov 17, 2022

Description

This PR fixes an issue concerning students' insertion from CSV, which occurs when the surname contains the (**) string (used by the portal to signal certain conditions). This includes the frontend, to appropriately remove it, and the backend, to prevent issues with names that end with a space (after the removal of invalid characters).

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Deploy staging

@giorio94 giorio94 added the kind/bug Something isn't working label Nov 17, 2022
@giorio94
Copy link
Member Author

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Hi @giorio94. Thanks for your PR.

I am @kingmakerbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /hold: Adds hold label to prevent merging with /merge
  • /unhold: Removes the hold label to allow merging with /merge
  • /deploy-staging: Deploy a staging environment to test this PR (the build-all flag enables user environments building)
  • /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@giorio94
Copy link
Member Author

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly deployed/updated!
Available here: Frontend, Qlkube
Operators: add the crownlabs.polito.it/operator-selector=staging-817 label to your tenant.

@giorio94 giorio94 marked this pull request as ready for review November 17, 2022 13:01
@giorio94 giorio94 requested a review from a team as a code owner November 17, 2022 13:01
@giorio94
Copy link
Member Author

/merge

@kingmakerbot kingmakerbot merged commit 6291d41 into netgroup-polito:master Nov 17, 2022
@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly teared-down!

@giorio94 giorio94 deleted the mio/fix-student-insertion branch January 6, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants