Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noVNC/websockify upgrade, cleanup and healthz #837

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

QcFe
Copy link
Collaborator

@QcFe QcFe commented Jan 12, 2023

Description

This PR

  • upgrades websockify (that includes noVNC) container dependencies and fixes compliance with net/http and grpc;
  • removes old noVNC container from pipelines;
  • changes the health probe of the containerized-vnc-based instance

How Has This Been Tested?

  • Unit tests
  • In-cluster staging

@kingmakerbot
Copy link
Collaborator

Hi @QcFe. Thanks for your PR.

I am @kingmakerbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /hold: Adds hold label to prevent merging with /merge
  • /unhold: Removes the hold label to allow merging with /merge
  • /deploy-staging: Deploy a staging environment to test this PR (the build-all flag enables user environments building)
  • /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@QcFe
Copy link
Collaborator Author

QcFe commented Jan 12, 2023

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly deployed/updated!
Available here: Frontend, Qlkube
Operators: add the crownlabs.polito.it/operator-selector=staging-837 label to your tenant.

@QcFe
Copy link
Collaborator Author

QcFe commented Jan 12, 2023

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly deployed/updated!
Available here: Frontend, Qlkube
Operators: add the crownlabs.polito.it/operator-selector=staging-837 label to your tenant.

@QcFe
Copy link
Collaborator Author

QcFe commented Jan 12, 2023

/merge

@kingmakerbot kingmakerbot merged commit 0ddeacf into master Jan 12, 2023
@kingmakerbot kingmakerbot deleted the qcfe/novnc-health branch January 12, 2023 16:51
@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly teared-down!

@giorio94 giorio94 added the kind/cleanup Refactoring code label Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants