New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Avatar Header (#356) #357
Merged
mateusz1913
merged 2 commits into
netguru:master
from
Vn-ChemGio:RNS-356_Fix_Avatar_header
Sep 13, 2022
Merged
Fix Avatar Header (#356) #357
mateusz1913
merged 2 commits into
netguru:master
from
Vn-ChemGio:RNS-356_Fix_Avatar_header
Sep 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: After header collapse miss image in HeaderBar * fix: Remove redundant space in HeaderBar when leftTopIcon or rightTopIcon doesn't provider
mateusz1913
approved these changes
Sep 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
@Vn-ChemGio could you fix lint issues before I can merge it?
|
Ok. @mateusz1913 mateusz1913 |
* fix: Remove redundant space in HeaderBar when leftTopIcon or rightTopIcon doesn't provider * fix: eslint * Update size text in avatar header
mateusz1913
approved these changes
Sep 13, 2022
Thx @Vn-ChemGio , your fix is available in v1.0.0-rc.9 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: After header collapse miss image in HeaderBar
fix: Remove redundant space in HeaderBar when leftTopIcon or rightTopIcon doesn't provider
This pull request resolves #356
Description
Affected platforms
Test plan/screenshots/videos