Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Avatar Header (#356) #357

Merged
merged 2 commits into from Sep 13, 2022
Merged

Fix Avatar Header (#356) #357

merged 2 commits into from Sep 13, 2022

Conversation

Vn-ChemGio
Copy link
Contributor

@Vn-ChemGio Vn-ChemGio commented Sep 12, 2022

  • fix: After header collapse miss image in HeaderBar

  • fix: Remove redundant space in HeaderBar when leftTopIcon or rightTopIcon doesn't provider

This pull request resolves #356

  • After header collapse miss image in HeaderBar
  • Remove redundant space in HeaderBar when leftTopIcon or rightTopIcon doesn't provider
    Description

Affected platforms

  • Android
  • iOS

Test plan/screenshots/videos

* fix: After header collapse miss image in HeaderBar

* fix: Remove redundant space in HeaderBar when leftTopIcon or rightTopIcon doesn't provider
Copy link
Contributor

@mateusz1913 mateusz1913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@mateusz1913
Copy link
Contributor

@Vn-ChemGio could you fix lint issues before I can merge it?

106:8   error  Delete `⏎········`                                                                                                          prettier/prettier
  109:31  error  Replace `·leftTopIconAccessibilityLabel·` with `leftTopIconAccessibilityLabel`                                              prettier/prettier
  111:20  error  Replace `·HIT_SLOP·` with `HIT_SLOP`                                                                                        prettier/prettier
  112:20  error  Replace `·leftTopIconOnPress·` with `leftTopIconOnPress`                                                                    prettier/prettier
  113:18  error  Replace `·styles.leftHeaderButton·` with `styles.leftHeaderButton`                                                          prettier/prettier
  114:19  error  Replace `·leftTopIconTestID·` with `leftTopIconTestID`                                                                      prettier/prettier
  115:31  error  Replace `·leftTopIcon·}` with `leftTopIcon}·`                                                                               prettier/prettier
  117:1   error  Replace `········)·:·null⏎······` with `······)·:·null`                                                                     prettier/prettier
  132:8   error  Replace `⏎········rightTopIcon·?⏎·······` with `rightTopIcon·?`                                                             prettier/prettier
  135:1   error  Delete `··`                                                                                                                 prettier/prettier
  136:11  error  Replace `··accessibilityLabel={·rightTopIconAccessibilityLabel·` with `accessibilityLabel={rightTopIconAccessibilityLabel`  prettier/prettier
  137:1   error  Replace `············` with `··········`                                                                                    prettier/prettier
  138:11  error  Replace `··hitSlop={·HIT_SLOP·` with `hitSlop={HIT_SLOP`                                                                    prettier/prettier
  139:1   error  Replace `············onPress={·rightTopIconOnPress·` with `··········onPress={rightTopIconOnPress`                          prettier/prettier
  140:1   error  Replace `············style={·styles.rightHeaderButton·` with `··········style={styles.rightHeaderButton`                    prettier/prettier
  141:1   error  Replace `············testID={·rightTopIconTestID·` with `··········testID={rightTopIconTestID`                              prettier/prettier
  142:11  error  Replace `··<IconRenderer·icon={·rightTopIcon·}` with `<IconRenderer·icon={rightTopIcon}·`                                   prettier/prettier
  143:9   error  Delete `··`                                                                                                                 prettier/prettier
  144:7   error  Replace `··)·:·null⏎······` with `)·:·null`                                                                                 prettier/prettier
✖ 19 problems (19 errors, 0 warnings)
  19 errors and 0 warnings potentially fixable with the `--fix` option.

@Vn-ChemGio
Copy link
Contributor Author

Ok. @mateusz1913 mateusz1913
I also see some other issue and will fix

* fix: Remove redundant space in HeaderBar when leftTopIcon or rightTopIcon doesn't provider
* fix: eslint
* Update size text in avatar header
@mateusz1913 mateusz1913 merged commit 2e1f9c5 into netguru:master Sep 13, 2022
@mateusz1913
Copy link
Contributor

Thx @Vn-ChemGio , your fix is available in v1.0.0-rc.9 🚀

@Vn-ChemGio Vn-ChemGio deleted the RNS-356_Fix_Avatar_header branch September 13, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show image in Avatar Header ScrollView after header collapse
2 participants