Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SlottedArray: empty storage path optimization #147

Closed
Scooletz opened this issue Aug 25, 2023 · 1 comment
Closed

SlottedArray: empty storage path optimization #147

Scooletz opened this issue Aug 25, 2023 · 1 comment
Labels
💾 disk size A change makes the disk size smaller good first issue Good for newcomers 🐌 performance Perofrmance related issue

Comments

@Scooletz
Copy link
Contributor

Scooletz commented Aug 25, 2023 •
edited
Loading

There are cases where there's no use in storing NibblePath.Empty that encoded, takes 1 byte of value 0. This can be approached in two ways. Either NibblePath.Empty should be changed so that it encoded always to Span<byte>.Empty or SlottedArray could use Key.Type and store the storage path only for Storage and Merkle. This could impact the disk size and increase packaging of data.
@Scooletz Scooletz added good first issue Good for newcomers 🐌 performance Perofrmance related issue 💾 disk size A change makes the disk size smaller labels Aug 25, 2023
@Scooletz Scooletz changed the title SlottedArray no storage optimization SlottedArray: empty storage path optimization Aug 26, 2023
@Scooletz
Copy link
Contributor Author

Scooletz commented Oct 6, 2023

SlottedArray component has been heavily reworked under #156 and now works with Spans only. This optimization is no longer needed.

@Scooletz Scooletz closed this as completed Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💾 disk size A change makes the disk size smaller good first issue Good for newcomers 🐌 performance Perofrmance related issue
Projects
Paprika
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Scooletz